From: Jeff King <peff@peff.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] Improve output of %p and %P format in git-rev-list --pretty=format:
Date: Wed, 28 Mar 2007 16:24:09 -0400 [thread overview]
Message-ID: <20070328202409.GA32092@coredump.intra.peff.net> (raw)
In-Reply-To: <20070328201123.GB2588@steel.home>
On Wed, Mar 28, 2007 at 10:11:23PM +0200, Alex Riesen wrote:
> Remove the terminating space from the space-separated list of parents.
> Also fix the test t6006: it wrongly assumed that the initial commit
> has a parent and was not executable.
Argh, yes. As is probably obvious, I moved the actual output to be
'expected' after giving it a cursory check, but I was more focused on
the author/committer information, since that's where I was fixing bugs.
Good catch.
This is obviously fairly untested code. I will follow up with a few
more tests for encoding/body to help make it more complete.
-Peff
prev parent reply other threads:[~2007-03-28 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-28 0:08 [PATCH] Add some basic tests of rev-list --pretty=format Jeff King
2007-03-28 19:21 ` Alex Riesen
2007-03-28 20:37 ` [PATCH] Fix "--pretty=format:" for parent related items Junio C Hamano
2007-03-28 20:11 ` [PATCH] Improve output of %p and %P format in git-rev-list --pretty=format: Alex Riesen
2007-03-28 20:24 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070328202409.GA32092@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).