git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Bisect: add checks at the beginning of "git bisect run".
Date: Thu, 29 Mar 2007 07:02:47 +0200	[thread overview]
Message-ID: <200703290702.47972.chriscool@tuxfamily.org> (raw)
In-Reply-To: <7vbqidls13.fsf@assigned-by-dhcp.cox.net>

Le mercredi 28 mars 2007 09:57, Junio C Hamano a écrit :
>
> In other words, the above would be equilvalent to
>
>   git bisect start
>   git bisect good nightly_2007_03_27
>   make >/dev/null || {
> 	  git bisect bad
>           git bisect run make >/dev/null
>           # extract commit and author email address from
> "$GIT_DIR/BISECT_RUN" # and send flame to author who broke the build with
> the commit }

Yes, it would be equivalent but a little shorter.

So while we are at it, what about a new subcommand "git bisect test" that 
could be used like this:

git bisect test good_rev my_script

equivalent to the following :

my_script || {
	git bisect start &&
	git bisect bad &&
	git bisect good good_rev &&
	git bisect run my_script
}

that could be used like this:

git bisect test good_rev my_script || {
	echo >&2 "my_script failed but 'git bisect test' failed too"
	exit 1
}
test -f "$GIT_DIR/BISECT_RUN" && {
	# extract commit and author email address from
	# "$GIT_DIR/BISECT_RUN" and send flames
	git bisect reset
}

Thanks,
Christian.

  reply	other threads:[~2007-03-29  4:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-27  4:49 [PATCH] Bisect: add checks at the beginning of "git bisect run" Christian Couder
2007-03-27  5:28 ` Junio C Hamano
2007-03-27  7:15   ` Christian Couder
2007-03-27  7:22     ` Junio C Hamano
2007-03-27  5:46 ` Junio C Hamano
2007-03-28  3:44   ` Christian Couder
2007-03-28  5:46     ` Junio C Hamano
2007-03-28  7:52       ` Christian Couder
2007-03-28  7:57         ` Junio C Hamano
2007-03-29  5:02           ` Christian Couder [this message]
2007-03-29  6:06             ` Junio C Hamano
2007-04-05  8:01               ` Christian Couder
2007-04-05  8:05                 ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703290702.47972.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).