From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Martin Koegler <mkoegler@auto.tuwien.ac.at>
Subject: Re: [PATCH (resend)] gitweb: Support comparing blobs (files) with different names
Date: Sat, 31 Mar 2007 01:41:35 +0200 [thread overview]
Message-ID: <200703310141.36552.jnareb@gmail.com> (raw)
In-Reply-To: <7virciz6gm.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
>> Fix the bug that caused "blobdiff" view called with new style URI
>> for a rename with change diff to be show as new (added) file diff.
[...]
>> ---
>> Junio, could you apply this? It looks like it was lost in the noise.
>
> I was waiting for dust to settle. Ack's from people involved in
> the discussion would be nice.
I can understand that.
This patch is _a_ solution: it fixes "blobdiff" view for all blobdiff
URIs gitweb generates now. But it is not _the_ solution, as it doesn't
work with Martin work on adding "(base | diff)" links to allow to view
diff between arbitrary commits, trees or blobs; which includes
"blobdiff" view of arbitrary blobs.
So if/when Martin finishes his series of patches, this part would be
rewritten. But it is some time in the future...
--
Jakub Narebski
Poland
prev parent reply other threads:[~2007-03-30 23:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 21:41 [PATCH (resend)] gitweb: Support comparing blobs (files) with different names Jakub Narebski
2007-03-30 22:56 ` Junio C Hamano
2007-03-30 23:41 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703310141.36552.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=mkoegler@auto.tuwien.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).