From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: git-add has gone lstat() mad
Date: Sun, 1 Apr 2007 09:25:24 +0100 [thread overview]
Message-ID: <200704010925.26590.andyparkins@gmail.com> (raw)
In-Reply-To: <7vy7ld3p33.fsf@assigned-by-dhcp.cox.net>
On Sunday 2007, April 01, Junio C Hamano wrote:
> But I like this patch better. We need to look at .gitignore to
> warn about adding ignored files, so we cannot just stuff what
> are found to dir without checking if they are ignored.
I needed the following needed on top of current pu:
diff --git a/unpack-trees.c b/unpack-trees.c
index fa36495..d4f7589 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -521,7 +521,7 @@ static void verify_clean_subdirectory(const char *path, const char *action,
memset(&d, 0, sizeof(d));
if (o->dir)
d.exclude_per_dir = o->dir->exclude_per_dir;
- i = read_directory(&d, path, pathbuf, namelen+1);
+ i = read_directory(&d, path, pathbuf, namelen+1, NULL);
if (i)
die("Updating '%s' would lose untracked files in it",
path);
prev parent reply other threads:[~2007-04-01 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 19:55 git-add has gone lstat() mad Andy Parkins
2007-03-30 20:20 ` Andy Parkins
2007-03-31 1:38 ` Junio C Hamano
2007-03-31 3:39 ` Linus Torvalds
2007-03-31 10:18 ` Andy Parkins
2007-03-31 14:54 ` Randal L. Schwartz
2007-03-31 15:09 ` Andy Parkins
2007-03-31 19:28 ` Tom Prince
2007-04-01 0:39 ` Junio C Hamano
2007-04-01 8:25 ` Andy Parkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704010925.26590.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).