From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Theodore Ts'o <tytso@mit.edu>,
git@vger.kernel.org, "Randal L. Schwartz" <merlyn@stonehenge.com>
Subject: Re: [PATCH] Rename warn() to warning() to fix symbol conflicts on BSD and Mac OS
Date: Sun, 1 Apr 2007 12:25:54 +0200 [thread overview]
Message-ID: <20070401102554.GA20579@steel.home> (raw)
In-Reply-To: <7vejn5ygkc.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano, Sat, Mar 31, 2007 10:15:31 +0200:
> >>I finally tracked down all the (albeit inconsequential) errors I was getting
> >>on both OpenBSD and OSX. It's the warn() function in usage.c. There's
> >>warn(3) in BSD-style distros. It'd take a "great rename" to change it, but if
> >>someone with better C skills than I have could do that, my linker and I would
> >>appreciate it.
> >
> > It was annoying to me, too, when I was doing some mergetool testing on
> > Mac OS X, so here's a fix.
>
> I'd take this for now, but I wonder where we should stop.
Glibc also has warn(3) - see err.h for example.
(why is it part of libc, I wonder...)
prev parent reply other threads:[~2007-04-01 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 23:07 [PATCH] Rename warn() to warning() to fix symbol conflicts on BSD and Mac OS Theodore Ts'o
2007-03-31 8:15 ` Junio C Hamano
2007-03-31 10:46 ` Johannes Schindelin
2007-03-31 14:48 ` Randal L. Schwartz
2007-04-01 10:25 ` Alex Riesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070401102554.GA20579@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=merlyn@stonehenge.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).