git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eygene Ryabinkin <rea-git@codelabs.ru>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] Fix drop-down menus in the git-gui dialogs.
Date: Thu, 5 Apr 2007 16:49:20 +0400	[thread overview]
Message-ID: <20070405124920.GV26348@codelabs.ru> (raw)
In-Reply-To: <20070404163709.GA5167@spearce.org>

Shawn, good day.

Wed, Apr 04, 2007 at 12:37:09PM -0400, Shawn O. Pearce wrote:
> git-gui patches should be addressed to me, not Paul.

Yep, I just messed with the mail addresses, since I was doing patches
both for gitk and git-gui. Sorry for it!

> > Error was fixed by "grab"bing the drop-down menu windows on their
> > activation. Now all drop-down menus are disappearing once the mouse
> > button is depressed, no matter what is the current position of the
> > mouse pointer.
> 
> This fix actually horribly breaks on Mac OS X.  The problem
> appears to be that the <Visibility> event on that system doesn't
> get delivered until after the menu is destroyed, yet I'm getting
> a %s of VisibilityUnobscured in the event handler.  Go figure.
>
> So anyway, I cannot apply this patch as-is, because it breaks
> my main development system.  I understand and feel your pain,
> but you either need to make this binding apply only on your OS,
> or find another way to workaround that Tk bug...

OK, I will try to find the other workaround, but I have no Mac OS
X at hand (they are a bit expensive to me), so I hope you will find
some time to test the new approaches, if I will come up with any.

Thank you!
-- 
Eygene

  reply	other threads:[~2007-04-05 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-27 10:30 [PATCH 2/4] Fix drop-down menus in the git-gui dialogs Eygene Ryabinkin
2007-04-04 16:37 ` Shawn O. Pearce
2007-04-05 12:49   ` Eygene Ryabinkin [this message]
2007-04-05 15:32     ` Shawn O. Pearce
2007-04-06  7:42       ` Eygene Ryabinkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070405124920.GV26348@codelabs.ru \
    --to=rea-git@codelabs.ru \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).