From: "Shawn O. Pearce" <spearce@spearce.org>
To: Eygene Ryabinkin <rea-git@codelabs.ru>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] Fix drop-down menus in the git-gui dialogs.
Date: Thu, 5 Apr 2007 11:32:26 -0400 [thread overview]
Message-ID: <20070405153226.GH5436@spearce.org> (raw)
In-Reply-To: <20070405124920.GV26348@codelabs.ru>
Eygene Ryabinkin <rea-git@codelabs.ru> wrote:
> Wed, Apr 04, 2007 at 12:37:09PM -0400, Shawn O. Pearce wrote:
> > git-gui patches should be addressed to me, not Paul.
>
> Yep, I just messed with the mail addresses, since I was doing patches
> both for gitk and git-gui. Sorry for it!
Not a problem, I just wanted to make sure you were aware that they
should come to me, so that you can leave poor paulus' inbox alone.
;-)
> > So anyway, I cannot apply this patch as-is, because it breaks
> > my main development system. I understand and feel your pain,
> > but you either need to make this binding apply only on your OS,
> > or find another way to workaround that Tk bug...
>
> OK, I will try to find the other workaround, but I have no Mac OS
> X at hand (they are a bit expensive to me), so I hope you will find
> some time to test the new approaches, if I will come up with any.
That's fine. I'd be happy to retest something. If I understood your
problem description right, this bug doesn't appear on either Cygwin's
Tcl/Tk implementation or my Mac OS X implementation. Maybe this
is one of those things that we just have to do conditionally per OS.
If that's the case, maybe we should also consider making our own
local variant of tk_optionMenu (a wrapper of sorts) that sets our
font_ui, and does this grab fix on your platform.
--
Shawn.
next prev parent reply other threads:[~2007-04-05 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 10:30 [PATCH 2/4] Fix drop-down menus in the git-gui dialogs Eygene Ryabinkin
2007-04-04 16:37 ` Shawn O. Pearce
2007-04-05 12:49 ` Eygene Ryabinkin
2007-04-05 15:32 ` Shawn O. Pearce [this message]
2007-04-06 7:42 ` Eygene Ryabinkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070405153226.GH5436@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=rea-git@codelabs.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).