From: "Shawn O. Pearce" <spearce@spearce.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dana How <danahow@gmail.com>, Nicolas Pitre <nico@cam.org>,
Junio C Hamano <junkio@cox.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-{repack,pack-objects} accept --{pack,blob}-limit to control pack size
Date: Thu, 5 Apr 2007 13:14:32 -0400 [thread overview]
Message-ID: <20070405171432.GK5436@spearce.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0704050910590.6730@woody.linux-foundation.org>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Thu, 5 Apr 2007, Shawn O. Pearce wrote:
> >
> > Sure, OK, but that libc function doesn't exist on Mac OS X:
>
> My bad. It's *not* linux-specific like the OSX man-page apparently says,
> it's very traditional. But the right name is "lseek64()" (and offt64_t for
> the size).
Sorry for the confusion, that manpage snippet came from a Gentoo/x86
system. But I digress, you are right, the right interfaces to be
using here is lseek64 and open64.
Now those also don't eixst on OSX, because as you pointed out, they
have no legacy to deal with and are just using sizeof off_t == 8.
So we'd probably have to do something like:
#ifndef _LFS_LARGEFILE
#define open64 open
#define lseek64 lseek
#endif
and then start using the open64/lseek64 variants instead. Or do
the reverse #define's. ;-)
--
Shawn.
next prev parent reply other threads:[~2007-04-05 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 20:40 [PATCH] git-{repack,pack-objects} accept --{pack,blob}-limit to control pack size Dana How
2007-04-04 22:04 ` Nicolas Pitre
2007-04-04 22:55 ` Dana How
2007-04-05 3:17 ` Nicolas Pitre
2007-04-05 7:15 ` Shawn O. Pearce
2007-04-05 15:52 ` Nicolas Pitre
2007-04-05 6:54 ` Shawn O. Pearce
2007-04-05 15:34 ` Linus Torvalds
2007-04-05 15:53 ` Shawn O. Pearce
2007-04-05 16:21 ` Linus Torvalds
2007-04-05 17:14 ` Shawn O. Pearce [this message]
2007-04-05 21:17 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070405171432.GK5436@spearce.org \
--to=spearce@spearce.org \
--cc=danahow@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).