From: arjen@yaph.org (Arjen Laarhoven)
To: Karl Hasselstr?m <kha@treskal.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Junio C Hamano <junkio@cox.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC/PATCH] Optimized PowerPC SHA1 generation for Darwin (OS X)
Date: Tue, 10 Apr 2007 13:45:07 +0200 [thread overview]
Message-ID: <20070410114507.GA28728@regex.yaph.org> (raw)
In-Reply-To: <20070410094801.GA6148@diana.vm.bytemark.co.uk>
Hi,
On Tue, Apr 10, 2007 at 11:48:01AM +0200, Karl Hasselstr?m wrote:
> On 2007-04-08 22:09:39 +0200, Arjen Laarhoven wrote:
>
> > ppc/{sha1ppc.S => sha1ppc.in.S} | 110 +++++++++++++++++++-------------------
>
> Wouldn't it be prettier if this filename was .S.in instead of .in.S?
> Additional file suffixes are usually added at the end (e.g. .tar.gz),
> and it makes more sense too.
Using the .S suffix makes gcc automatically do the right thing. .S.in
requires an extra '-x assembler-with-cpp' option to gcc. Of course,
it's trivial fix.
Arjen
next prev parent reply other threads:[~2007-04-10 11:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 23:48 [RFC/PATCH] Optimized PowerPC SHA1 generation for Darwin (OS X) Arjen Laarhoven
2007-04-07 0:47 ` Junio C Hamano
2007-04-07 1:40 ` Linus Torvalds
2007-04-08 20:09 ` Arjen Laarhoven
2007-04-10 9:48 ` Karl Hasselström
2007-04-10 11:45 ` Arjen Laarhoven [this message]
2007-04-10 13:00 ` Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070410114507.GA28728@regex.yaph.org \
--to=arjen@yaph.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=kha@treskal.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).