From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Don Zickus <dzickus@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: git-quiltimport complaining yet still working
Date: Fri, 13 Apr 2007 20:57:26 -0700 [thread overview]
Message-ID: <20070414035726.GA6488@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0704131431040.28042@woody.linux-foundation.org>
On Fri, Apr 13, 2007 at 02:34:18PM -0700, Linus Torvalds wrote:
>
>
> On Fri, 13 Apr 2007, Greg KH wrote:
> >
> > In git 1.5.1 the quiltimport function started complaining in a new way:
> >
> > libata-clear-tf-before-doing-request-sense.patch
> > Patch is empty. Was is split wrong?
> > /usr/bin/git-quiltimport: line 78: stop_here: command not found
>
> This is an *old* bug. It got fixed once already. Did it get re-introduced?
>
> Ahh - somebody copied the bug from git-applymbox
>
> > Any hints? Or is it time to start bisecting?
>
> This should fix it.
>
> There were two bugs: "stop_here" doesn't exist, but the bug that causes
> this code to trigger in the *first* place is the wrong use of "$dotest".
> It should be ".dotest"
Thanks, that seems to do the trick for me.
greg k-h
prev parent reply other threads:[~2007-04-14 4:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-13 20:38 git-quiltimport complaining yet still working Greg KH
2007-04-13 21:13 ` Don Zickus
2007-04-13 21:19 ` Greg KH
2007-04-13 21:34 ` Linus Torvalds
2007-04-13 22:42 ` Junio C Hamano
2007-04-14 3:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070414035726.GA6488@kroah.com \
--to=greg@kroah.com \
--cc=dzickus@gmail.com \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).