git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] git-bisect: allow bisecting with only one bad commit.
Date: Tue, 17 Apr 2007 07:07:10 +0200	[thread overview]
Message-ID: <200704170707.10938.chriscool@tuxfamily.org> (raw)
In-Reply-To: <7v7isqkoa3.fsf_-_@assigned-by-dhcp.cox.net>

Hi Junio,

You wrote:

[...]
> -test_expect_success 'bisect does not start with only one bad' '
> +test_expect_success 'bisect starts with only one bad' '
>  	git bisect reset &&
>  	git bisect start &&
> -	git bisect bad $HASH4 || return 1
> -
> -	if git bisect next
> -	then
> -		echo Oops, should have failed.
> -		false
> -	else
> -		:
> -	fi
> +	git bisect bad $HASH4 &&
> +	git bisect next
>  '

Ok, this is the purpose of your patch to make the above work.

> -test_expect_success 'bisect does not start with only one good' '
> +test_expect_success 'bisect starts with only one good' '
>  	git bisect reset &&
>  	git bisect start &&
>  	git bisect good $HASH1 || return 1

But I don't understand the need to change the above comment when the test 
code for starting with one good commit is not changed.

Thanks,
Christian.

  reply	other threads:[~2007-04-17  4:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-01 12:57 [RFC/PATCH] Bisect: teach "bisect start" to optionally use one bad and many good revs Christian Couder
2007-04-03 20:02 ` Junio C Hamano
2007-04-04  5:12   ` [PATCH] " Christian Couder
2007-04-05  3:33     ` [PATCH] Documentation: bisect: "start" accepts one bad and many good commits Christian Couder
2007-04-05  4:55       ` Junio C Hamano
2007-04-06  6:30     ` [PATCH 2/2] git-bisect: allow bisecting with only one bad commit Junio C Hamano
2007-04-17  5:07       ` Christian Couder [this message]
2007-04-17  5:03         ` Junio C Hamano
2007-04-06  6:30     ` [PATCH 1/2] t6030: add a bit more tests to git-bisect Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704170707.10938.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).