git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Steven Grimm <koreth@midwinter.com>
Cc: git@vger.kernel.org
Subject: Re: Segmentation fault in git-svn
Date: Tue, 17 Apr 2007 02:55:09 -0700	[thread overview]
Message-ID: <20070417095509.GA24800@muzzle> (raw)
In-Reply-To: <20070417093743.GA9222@muzzle>

This disables some pool allocations, forcing it to use the
global one.

Other than that, my eyes are barely open and my brain is
having trouble functioning at this time of morning.

diff --git a/git-svn.perl b/git-svn.perl
index ac44f60..cff81f7 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2883,7 +2883,7 @@ BEGIN {
 			wantarray ? \@ret : \$ret[0]; }\n";
 	}
 	$e .= "\n1;";
-	eval $e or die $@;
+	# eval $e or die $@;
 }
 
 sub new {
@@ -2925,10 +2925,10 @@ sub DESTROY {
 
 sub get_log {
 	my ($self, @args) = @_;
-	my $pool = SVN::Pool->new;
+	# my $pool = SVN::Pool->new;
 	splice(@args, 3, 1) if ($SVN::Core::VERSION le '1.2.0');
-	my $ret = $self->SUPER::get_log(@args, $pool);
-	$pool->clear;
+	my $ret = $self->SUPER::get_log(@args);
+	# $pool->clear;
 	$ret;
 }
 
-- 
Eric Wong

  parent reply	other threads:[~2007-04-17  9:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-16 22:17 Segmentation fault in git-svn Steven Grimm
2007-04-17  9:37 ` Eric Wong
2007-04-17  9:40   ` [PATCH (WIP)] git-svn: cache SVN::Ra functions in a more Perl GC-friendly way Eric Wong
2007-04-24  0:50     ` Steven Grimm
2007-04-25  6:40       ` Eric Wong
2007-04-17  9:55   ` Eric Wong [this message]
2007-04-18  9:01     ` Segmentation fault in git-svn Eric Wong
2007-04-19 21:31       ` [RFH] " Eric Wong
2007-05-03 12:35 ` Peter Baumann
2007-05-13  8:21   ` Eric Wong
2007-05-13 22:04     ` Steven Grimm
2007-05-14  9:02       ` Peter Baumann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070417095509.GA24800@muzzle \
    --to=normalperson@yhbt.net \
    --cc=git@vger.kernel.org \
    --cc=koreth@midwinter.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).