From: Alex Riesen <raa.lkml@gmail.com>
To: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Cc: Junio C Hamano <junkio@cox.net>,
Jakub Narebski <jnareb@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/4] add mode parameter to get_sha1
Date: Sat, 21 Apr 2007 22:02:39 +0200 [thread overview]
Message-ID: <20070421200239.GA2437@steel.home> (raw)
In-Reply-To: <1177158380197-git-send-email-mkoegler@auto.tuwien.ac.at>
Martin Koegler, Sat, Apr 21, 2007 14:26:17 +0200:
> If the mode parameter is not NULL, get_sha1 will store
> the mode of the object in it.
It looks like the number of call sites which actually use the
argument is vanishingly small compared to the number of sites
where it is set to NULL. Why don't you introduce a new function
instead, say get_sha1_and_mode, and use it for this two or three
places?
prev parent reply other threads:[~2007-04-21 20:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-21 12:26 [PATCH 1/4] add mode parameter to get_sha1 Martin Koegler
2007-04-21 12:26 ` [PATCH 2/4] add support for storing the mode in object_array Martin Koegler
2007-04-21 12:26 ` [PATCH 3/4] add mode to add_pending_object Martin Koegler
2007-04-21 12:26 ` [PATCH 4/4] use the mode information of the tree, if <SHA1>:file name syntax is used Martin Koegler
2007-04-21 18:42 ` [PATCH 1/4] add mode parameter to get_sha1 Junio C Hamano
2007-04-21 20:02 ` Alex Riesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070421200239.GA2437@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=junkio@cox.net \
--cc=mkoegler@auto.tuwien.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).