From: Alex Riesen <raa.lkml@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>, Martin Waitz <tali@admingilde.org>
Subject: Re: [PATCH] Fix crash in t0020 (crlf conversion)
Date: Mon, 23 Apr 2007 00:52:47 +0200 [thread overview]
Message-ID: <20070422225247.GA2409@steel.home> (raw)
In-Reply-To: <20070422141222.GC2431@steel.home> <20070422141154.GB2431@steel.home>
Alex Riesen, Sun, Apr 22, 2007 16:11:54 +0200:
> Reallocated wrong size.
> Noticed on Ubuntu 7.04 probably because it has some malloc diagnostics in libc:
> "git-read-tree --reset -u HEAD" aborted in the test. Valgrind sped up the
> debugging greatly: took me 10 minutes.
Alex Riesen, Sun, Apr 22, 2007 16:12:22 +0200:
> Also, noticed by valgrind: the code caused a read out-of-bounds.
> Some comments updated as well (they still reflected old calling
> conventions).
Actually, it is all the other way around. The _second_ patch
(buffer->src in convert.c, the read out-of-bounds caused overwrite of
malloc control structures because of incorrect dst update condition)
is for the crash, the first is unrelated, but noticed by valgrind
in the same test.
I messed up the commit descriptions completely (Martins mail made
me look at the patches again). Sorry
prev parent reply other threads:[~2007-04-22 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-22 14:12 [PATCH] Fix a typo in crlf conversion code Alex Riesen
2007-04-22 14:11 ` [PATCH] Fix crash in t0020 (crlf conversion) Alex Riesen
2007-04-22 22:52 ` Alex Riesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070422225247.GA2409@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=tali@admingilde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).