From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: git@vger.kernel.org
Subject: Re: [EGIT PATCH 2/4] Use the Git sort order.
Date: Tue, 24 Apr 2007 13:09:18 -0400 [thread overview]
Message-ID: <20070424170918.GA5923@spearce.org> (raw)
In-Reply-To: <200704240039.48892.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> Oops, lost the decoration here.
Thanks, I applied all 6 patches. Good stuff.
Unfortunately this particular patch was totally damaged beyond
repair. What happened to it? I redid the changes by hand, as even
after fixing the line wrapping on the `diff --git` header line
`git-am -3 --whitespace=strip` was unable to apply the patch to
0c4683e. The patch doesn't apply, at all, to that blob.
> diff --git a/org.spearce.egit.core/src/org/spearce/egit/core/project/GitProjectData.java b/org.spearce.egit.core/src/org/spearce/egit
> /core/project/GitProjectData.java
> index 0c4683e..5c250c0 100644
> --- a/org.spearce.egit.core/src/org/spearce/egit/core/project/GitProjectData.java
> +++ b/org.spearce.egit.core/src/org/spearce/egit/core/project/GitProjectData.java
> @@ -274,11 +274,11 @@ public class GitProjectData {
> return (RepositoryMapping) c2mapping.get(r);
> }
>
> - public TreeEntry[] getActiveDiffTreeEntries(IResource r)
> + public TreeEntry[] getActiveDiffTreeEntries(IResource res)
> throws CoreException {
> String s = null;
> RepositoryMapping m = null;
> -
> + IResource r = res;
> while (r != null) {
> m = getRepositoryMapping(r);
> if (m != null) {
> @@ -296,7 +296,7 @@ public class GitProjectData {
>
> if (s != null && m != null && m.getActiveDiff() != null) {
> try {
> - if (r.getType() == IResource.FILE)
> + if (res.getType() == IResource.FILE)
> return m.getActiveDiff().findBlobMember(s);
> else
> return m.getActiveDiff().findTreeMember(s);
--
Shawn.
next prev parent reply other threads:[~2007-04-24 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-22 21:35 [EGIT PATCH 0/4] Unit test for plugin and then some Robin Rosenberg
2007-04-22 21:35 ` [EGIT PATCH 1/4] Drop unneeded GitTreeStorage Robin Rosenberg
2007-04-22 21:36 ` [EGIT PATCH 2/4] Use the Git sort order Robin Rosenberg
2007-04-23 22:39 ` Robin Rosenberg
2007-04-24 17:09 ` Shawn O. Pearce [this message]
2007-04-22 21:36 ` [EGIT PATCH 3/4] Add writeRef method and make writeSymref public Robin Rosenberg
2007-04-22 21:36 ` [EGIT PATCH 4/4] Add a JUnit test project for egit Robin Rosenberg
2007-04-23 22:41 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424170918.GA5923@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg.lists@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).