From: "Karl Hasselström" <kha@treskal.com>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: git@vger.kernel.org
Subject: [StGIT PATCH 1/2] String comparison is done with "=", not "=="
Date: Sun, 29 Apr 2007 23:09:50 +0200 [thread overview]
Message-ID: <20070429210950.4004.86948.stgit@yoghurt> (raw)
In-Reply-To: <20070429210713.4004.60467.stgit@yoghurt>
From: Karl Hasselström <kha@treskal.com>
The "test" builtin in bash accepts both "==" and "=", but it didn't
work with dash as /bin/sh.
Signed-off-by: Karl Hasselström <kha@treskal.com>
---
t/t1300-uncommit.sh | 8 ++++----
t/t1800-import.sh | 26 +++++++++++++-------------
t/t1900-mail.sh | 2 +-
t/t2000-sync.sh | 14 +++++++-------
4 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/t/t1300-uncommit.sh b/t/t1300-uncommit.sh
index 497c354..519234e 100755
--- a/t/t1300-uncommit.sh
+++ b/t/t1300-uncommit.sh
@@ -42,7 +42,7 @@ test_expect_success \
'Uncommit the patches using names' \
'
stg uncommit bar foo &&
- [ "$(stg id foo//top)" == "$(stg id bar//bottom)" ] &&
+ [ "$(stg id foo//top)" = "$(stg id bar//bottom)" ] &&
stg commit
'
@@ -50,7 +50,7 @@ test_expect_success \
'Uncommit the patches using prefix' \
'
stg uncommit --number=2 foobar &&
- [ "$(stg id foobar1//top)" == "$(stg id foobar2//bottom)" ] &&
+ [ "$(stg id foobar1//top)" = "$(stg id foobar2//bottom)" ] &&
stg commit
'
@@ -58,7 +58,7 @@ test_expect_success \
'Uncommit the patches using auto names' \
'
stg uncommit --number=2 &&
- [ "$(stg id foo-patch//top)" == "$(stg id bar-patch//bottom)" ] &&
+ [ "$(stg id foo-patch//top)" = "$(stg id bar-patch//bottom)" ] &&
stg commit
'
@@ -67,7 +67,7 @@ test_expect_success \
'
stg uncommit &&
stg uncommit &&
- [ "$(stg id foo-patch//top)" == "$(stg id bar-patch//bottom)" ] &&
+ [ "$(stg id foo-patch//top)" = "$(stg id bar-patch//bottom)" ] &&
stg commit
'
test_done
diff --git a/t/t1800-import.sh b/t/t1800-import.sh
index 0c1baa3..ed10fa8 100755
--- a/t/t1800-import.sh
+++ b/t/t1800-import.sh
@@ -19,7 +19,7 @@ test_expect_success \
'
stg import ../t1800-import/git-diff &&
[ $(git cat-file -p $(stg id) \
- | grep -c "tree e96b1fba2160890ff600b675d7140d46b022b155") == 1 ] &&
+ | grep -c "tree e96b1fba2160890ff600b675d7140d46b022b155") = 1 ] &&
stg delete ..
'
@@ -28,7 +28,7 @@ test_expect_success \
'
stg import ../t1800-import/gnu-diff &&
[ $(git cat-file -p $(stg id) \
- | grep -c "tree e96b1fba2160890ff600b675d7140d46b022b155") == 1 ] &&
+ | grep -c "tree e96b1fba2160890ff600b675d7140d46b022b155") = 1 ] &&
stg delete ..
'
@@ -37,7 +37,7 @@ test_expect_success \
'
stg import ../t1800-import/stg-export &&
[ $(git cat-file -p $(stg id) \
- | grep -c "tree e96b1fba2160890ff600b675d7140d46b022b155") == 1 ] &&
+ | grep -c "tree e96b1fba2160890ff600b675d7140d46b022b155") = 1 ] &&
stg delete ..
'
@@ -46,9 +46,9 @@ test_expect_success \
'
stg import -m ../t1800-import/email-8bit &&
[ $(git cat-file -p $(stg id) \
- | grep -c "tree 030be42660323ff2a1958f9ee79589a4f3fbee2f") == 1 ] &&
+ | grep -c "tree 030be42660323ff2a1958f9ee79589a4f3fbee2f") = 1 ] &&
[ $(git cat-file -p $(stg id) \
- | grep -c "author Inge Ström <inge@power.com>") == 1 ] &&
+ | grep -c "author Inge Ström <inge@power.com>") = 1 ] &&
stg delete ..
'
@@ -57,9 +57,9 @@ test_expect_success \
'
stg import -m ../t1800-import/email-qp &&
[ $(git cat-file -p $(stg id) \
- | grep -c "tree 030be42660323ff2a1958f9ee79589a4f3fbee2f") == 1 ] &&
+ | grep -c "tree 030be42660323ff2a1958f9ee79589a4f3fbee2f") = 1 ] &&
[ $(git cat-file -p $(stg id) \
- | grep -c "author Inge Ström <inge@power.com>") == 1 ] &&
+ | grep -c "author Inge Ström <inge@power.com>") = 1 ] &&
stg delete ..
'
@@ -68,17 +68,17 @@ test_expect_success \
'
stg import -M ../t1800-import/email-mbox &&
[ $(git cat-file -p $(stg id change-1) \
- | grep -c "tree 401bef82cd9fb403aba18f480a63844416a2e023") == 1 ] &&
+ | grep -c "tree 401bef82cd9fb403aba18f480a63844416a2e023") = 1 ] &&
[ $(git cat-file -p $(stg id change-1) \
- | grep -c "author Inge Ström <inge@power.com>") == 1 ] &&
+ | grep -c "author Inge Ström <inge@power.com>") = 1 ] &&
[ $(git cat-file -p $(stg id change-2) \
- | grep -c "tree e49dbce010ec7f441015a8c64bce0b99108af4cc") == 1 ] &&
+ | grep -c "tree e49dbce010ec7f441015a8c64bce0b99108af4cc") = 1 ] &&
[ $(git cat-file -p $(stg id change-2) \
- | grep -c "author Inge Ström <inge@power.com>") == 1 ] &&
+ | grep -c "author Inge Ström <inge@power.com>") = 1 ] &&
[ $(git cat-file -p $(stg id change-3) \
- | grep -c "tree 166bbaf27a44aee21ba78c98822a741e6f7d78f5") == 1 ] &&
+ | grep -c "tree 166bbaf27a44aee21ba78c98822a741e6f7d78f5") = 1 ] &&
[ $(git cat-file -p $(stg id change-3) \
- | grep -c "author Inge Ström <inge@power.com>") == 1 ] &&
+ | grep -c "author Inge Ström <inge@power.com>") = 1 ] &&
stg delete ..
'
diff --git a/t/t1900-mail.sh b/t/t1900-mail.sh
index 3eed7f8..78050db 100755
--- a/t/t1900-mail.sh
+++ b/t/t1900-mail.sh
@@ -29,7 +29,7 @@ test_expect_success \
stg pop -a &&
stg import -M mbox0 &&
t2=$(git cat-file -p $(stg id) | grep ^tree) &&
- [ "$t1" == "$t2" ]
+ [ "$t1" = "$t2" ]
'
test_done
diff --git a/t/t2000-sync.sh b/t/t2000-sync.sh
index 3dd1cd6..02345bb 100755
--- a/t/t2000-sync.sh
+++ b/t/t2000-sync.sh
@@ -47,7 +47,7 @@ test_expect_success \
'
stg sync -b master p2 &&
test $(stg applied -c) -eq 3 &&
- test $(cat foo2.txt) == "foo2"
+ test $(cat foo2.txt) = "foo2"
'
test_expect_success \
@@ -55,8 +55,8 @@ test_expect_success \
'
stg sync -b master -a &&
test $(stg applied -c) -eq 3 &&
- test $(cat foo1.txt) == "foo1" &&
- test $(cat foo2.txt) == "foo2"
+ test $(cat foo1.txt) = "foo1" &&
+ test $(cat foo2.txt) = "foo2"
'
test_expect_success \
@@ -64,9 +64,9 @@ test_expect_success \
'
stg sync -s patches-master/series -a &&
test $(stg applied -c) -eq 3 &&
- test $(cat foo1.txt) == "foo1" &&
- test $(cat foo2.txt) == "foo2" &&
- test $(cat foo3.txt) == "foo3"
+ test $(cat foo1.txt) = "foo1" &&
+ test $(cat foo2.txt) = "foo2" &&
+ test $(cat foo3.txt) = "foo3"
'
test_expect_success \
@@ -92,7 +92,7 @@ test_expect_success \
'
stg sync -b master p2 &&
test $(stg applied -c) -eq 3 &&
- test $(cat bar2.txt) == "bar2"
+ test $(cat bar2.txt) = "bar2"
'
test_expect_failure \
next prev parent reply other threads:[~2007-04-29 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-29 21:09 [StGIT PATCH 0/2] Make test suite work with dash as /bin/sh Karl Hasselström
2007-04-29 21:09 ` Karl Hasselström [this message]
2007-04-29 21:09 ` [StGIT PATCH 2/2] dash doesn't do curly brace expansion, so avoid that Karl Hasselström
2007-04-29 22:44 ` [StGIT PATCH 0/2] Make test suite work with dash as /bin/sh Catalin Marinas
2007-04-30 7:08 ` Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070429210950.4004.86948.stgit@yoghurt \
--to=kha@treskal.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).