Git development
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>
Subject: [PATCH] Include mailmap.h in mailmap.c to catch mailmap interface changes
Date: Tue, 1 May 2007 00:31:52 +0200	[thread overview]
Message-ID: <20070430223152.GD5000@steel.home> (raw)

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

And an interface change it could use. There is only two users, and
only one needs repo_abbrev. Maybe put all mailmap data into a
structure, and pass a pointer to that structure to read_mailmap?
Not proposing it, though. Not worth the effort: mailmaps aren't very
popular (and maybe not even used, if one remembers how inconsistent
local mail configurations are).

 mailmap.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/mailmap.c b/mailmap.c
index 38359a2..cb567a2 100644
--- a/mailmap.c
+++ b/mailmap.c
@@ -1,5 +1,6 @@
 #include "cache.h"
 #include "path-list.h"
+#include "mailmap.h"
 
 int read_mailmap(struct path_list *map, const char *filename, char **repo_abbrev)
 {
-- 
1.5.2.rc0.792.g7f4bd0

                 reply	other threads:[~2007-04-30 22:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070430223152.GD5000@steel.home \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox