From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>
Subject: Re: git-blame not tracking copies
Date: Thu, 3 May 2007 08:29:30 +0100 [thread overview]
Message-ID: <200705030829.31144.andyparkins@gmail.com> (raw)
In-Reply-To: <7v8xc64wsu.fsf@assigned-by-dhcp.cox.net>
On Thursday 2007 May 03, Junio C Hamano wrote:
> I am sick and not functioning well today, so will not be able to
I'm sorry to hear that. I hope you feel better soon.
> review what is happening with your example deeply, but here are
> some comments to get you started digging.
>
> There is a built-in sanity valve in git-blame that refuses to
> pass down the blame via -M/-C for really trivial hunks. Without
> such safety, all the empty lines in the latest revision would be
> attributed to a random empty line in a random file in the root
> commit ;-).
That sounds like an excellent feature. However - in the case of a full
file-to-file copy, surely that valve may be safely disabled for that one
step?
The copy is easily detectable because the hash is the same, so can't git-blame
just continue having flipped itself on to the original filename? I suppose
in essence a move is the same, the only difference between a move and a copy
is that in one case the copy is spatial in the other it is temporal.
Please excuse the fact that in the above I've completely minimised the fact
the job git-blame does is flippin' hard; I don't mean to imply that "any fule
could fix it" - because I can't :-)
Andy
--
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
next prev parent reply other threads:[~2007-05-03 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 19:33 git-blame not tracking copies Andy Parkins
2007-05-02 23:42 ` Junio C Hamano
2007-05-03 7:29 ` Andy Parkins [this message]
2007-05-06 6:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705030829.31144.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).