From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: spearce@spearce.org
Cc: git@vger.kernel.org
Subject: [EGIT PATCH 02/10] Recursion and update of all elements regardless of need.
Date: Mon, 07 May 2007 23:29:20 +0200 [thread overview]
Message-ID: <20070507212919.21546.75269.stgit@lathund.dewire.com> (raw)
In-Reply-To: <20070507212636.21546.29280.stgit@lathund.dewire.com>
When selecting an element in the history view viewer.updateElement
is called for every element recursively. If the number of
elements is very largs this results in a stack overflow. This
only happens with Eclipse 3.3 M7 and not M6.
Is it thig bug? https://bugs.eclipse.org/bugs/show_bug.cgi?id=149642
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---
.../src/org/spearce/egit/ui/GitHistoryPage.java | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java
index 7bc947b..8be23ec 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/GitHistoryPage.java
@@ -281,6 +281,8 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,
viewer = new TreeViewer(tree, SWT.VIRTUAL | SWT.FULL_SELECTION);
+ viewer.setUseHashlookup(true);
+
createColumns();
viewer.setLabelProvider(new GitHistoryLabelProvider());
@@ -354,6 +356,7 @@ public class GitHistoryPage extends HistoryPage implements IAdaptable,
}
public void updateElement(Object parent, int index) {
+ System.out.println("updateElement("+parent+","+index);
viewer.replace(parent, index, fileRevisions[index]);
}
}
next prev parent reply other threads:[~2007-05-07 21:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 21:29 [EGIT 00/10] This weeks Eclipse patches Robin Rosenberg
2007-05-07 21:29 ` [EGIT PATCH 01/10] Fixes due to changes in the Eclipse Team API Robin Rosenberg
2007-05-07 21:29 ` Robin Rosenberg [this message]
2007-05-07 21:29 ` [EGIT PATCH 03/10] Update compare window immediately Robin Rosenberg
2007-05-07 21:29 ` [EGIT PATCH 04/10] Bug: Do not crash when showing diff for first version of a file Robin Rosenberg
2007-05-07 21:29 ` [EGIT PATCH 05/10] Speed up ObjectId a little Robin Rosenberg
2007-05-07 21:29 ` [EGIT PATCH 06/10] Create a generic history walker Robin Rosenberg
2007-05-07 21:29 ` [EGIT PATCH 07/10] Cache pack index fully Robin Rosenberg
2007-05-07 21:29 ` [EGIT PATCH 08/10] Use ObjectId[] instead of List for parents Robin Rosenberg
2007-05-07 21:30 ` [EGIT PATCH 09/10] Run history refresh in background Robin Rosenberg
2007-05-07 21:30 ` [EGIT PATCH 10/10] Enable a tooltip in the history view Robin Rosenberg
2007-05-07 21:35 ` Eclipse support status (was: Re: [EGIT 00/10] This weeks Eclipse patches) Grzegorz Kulewski
2007-05-08 2:07 ` Shawn O. Pearce
2007-05-08 3:24 ` [EGIT 00/10] This weeks Eclipse patches Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070507212919.21546.75269.stgit@lathund.dewire.com \
--to=robin.rosenberg@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).