From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Git.pm: config_boolean() -> config_bool()
Date: Wed, 9 May 2007 17:13:37 +0200 [thread overview]
Message-ID: <20070509151337.GX4489@pasky.or.cz> (raw)
In-Reply-To: <20070509104941.GK4489@pasky.or.cz>
On Wed, May 09, 2007 at 12:49:41PM CEST, Petr Baudis wrote:
> @@ -526,14 +528,16 @@ This currently wraps command('config') so it is not so fast.
>
> =cut
>
> -sub config_boolean {
> +sub config_bool {
> my ($self, $var) = @_;
> $self->repo_path()
> or throw Error::Simple("not a repository");
>
> try {
> - return $self->command_oneline('config', '--bool', '--get',
> - $var);
> + my $val = $self->command_oneline('config', '--bool', '--get',
> + $val);
^^^
Sorry, should be $var. Looks like I forgot to make install or something
when "testing" the patch, also judging by the error messages repo.or.cz
spewed furiously in the last update round.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
-- Samuel Beckett
next prev parent reply other threads:[~2007-05-09 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 2:06 [PATCH 1/4] Git.pm: config_boolean() -> config_bool() Petr Baudis
2007-04-27 2:06 ` [PATCH 2/4] Git.pm: Add remote_refs() git-ls-remote frontend Petr Baudis
2007-04-27 2:06 ` [PATCH 3/4] [PATCH] git-mirror - exactly mirror another repository Petr Baudis
2007-04-27 4:39 ` Shawn O. Pearce
2007-04-27 2:06 ` [PATCH 4/4] server info: Add HEAD to info/refs Petr Baudis
2007-04-27 3:51 ` Junio C Hamano
2007-04-27 4:28 ` Petr Baudis
2007-04-27 4:36 ` Junio C Hamano
2007-04-28 6:27 ` [PATCH 1/4] Git.pm: config_boolean() -> config_bool() Junio C Hamano
2007-05-09 10:49 ` [PATCH] " Petr Baudis
2007-05-09 15:13 ` Petr Baudis [this message]
2007-05-10 2:12 ` Junio C Hamano
2007-05-09 15:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509151337.GX4489@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).