From: Frank Lichtenheld <frank@lichtenheld.de>
To: junkio@cox.net, git@vger.kernel.org
Subject: Re: [PATCH] t9400: Use the repository config and nothing else.
Date: Sat, 12 May 2007 18:28:20 +0200 [thread overview]
Message-ID: <20070512162819.GA7184@planck.djpig.de> (raw)
In-Reply-To: <7v8xbvj5mx.fsf@arte.twinsun.com>
On Fri, May 11, 2007 at 04:35:18PM -0700, Junio Hamano wrote:
> This needs to be fixed, but thanks to that bug, a separate bug
> in t9400 test script was discovered. The test discarded
> GIT_CONFIG instead of pointing at the proper one to be used in
> the exoprted repository. This allowed user's .gitconfig and (if
> exists) systemwide /etc/gitconfig to affect the outcome of the
> test, which is a big no-no.
Shouldn't you also remove the "unset GIT_CONFIG" then?
> @@ -26,6 +26,7 @@ perl -e 'use DBI; use DBD::SQLite' >/dev/null 2>&1 || {
> unset GIT_DIR GIT_CONFIG
> WORKDIR=$(pwd)
> SERVERDIR=$(pwd)/gitcvs.git
> +git_config=$SERVERDIR/config
> CVSROOT=":fork:$SERVERDIR"
> CVSWORK=$(pwd)/cvswork
Gruesse,
--
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/
next prev parent reply other threads:[~2007-05-12 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 23:35 [PATCH] t9400: Use the repository config and nothing else Junio Hamano
2007-05-12 16:28 ` Frank Lichtenheld [this message]
2007-05-12 16:31 ` Junio C Hamano
2007-05-12 17:21 ` Junio C Hamano
2007-05-12 19:36 ` Frank Lichtenheld
2007-05-12 19:30 ` [PATCH] cvsserver: Complete rewrite of the configuration parser Frank Lichtenheld
2007-05-12 19:59 ` Junio C Hamano
2007-05-12 21:31 ` Frank Lichtenheld
2007-05-12 22:43 ` Junio C Hamano
2007-05-13 0:16 ` [PATCH] cvsserver: Limit config parser to needed options Frank Lichtenheld
2007-05-13 19:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070512162819.GA7184@planck.djpig.de \
--to=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).