git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <junkio@cox.net>
Cc: Martin Eisenhardt <martin.eisenhardt@mneisen.org>,
	Adam Roben <aroben@apple.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: [PATCH] git-svn: don't drop the username from URLs when dcommit is run
Date: Sun, 13 May 2007 00:53:16 -0700	[thread overview]
Message-ID: <20070513075316.GA1168@muzzle> (raw)
In-Reply-To: <20070512214035.GA18560@muzzle>

Eric Wong <normalperson@yhbt.net> wrote:
> Martin Eisenhardt <list-receive@mneisen.org> wrote:
> 
> Thanks for the bug report.  I haven't tested the patch below, so
> let me know if it works:

Junio: I've confirmed this patch works, please apply.  Thanks.

>From 58af622c222514dc3da938ce6309e1ac927a9574 Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson@yhbt.net>
Date: Sat, 12 May 2007 14:36:20 -0700
Subject: [PATCH] git-svn: don't drop the username from URLs when dcommit is run

We no longer store usernames in URLs stored in git-svn-id lines
for dcommit, so we shouldn't rely on those URLs when connecting
to the remote repository to commit.
---
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 3c4f490..d74e6d3 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -393,7 +393,7 @@ sub cmd_dcommit {
 		} else {
 			my %ed_opts = ( r => $last_rev,
 			                log => get_commit_entry($d)->{log},
-			                ra => Git::SVN::Ra->new($url),
+			                ra => Git::SVN::Ra->new($gs->full_url),
 			                tree_a => "$d~1",
 			                tree_b => $d,
 			                editor_cb => sub {
-- 
Eric Wong

  reply	other threads:[~2007-05-13  7:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-12 16:24 Possible bug in git-svn Martin Eisenhardt
2007-05-12 21:40 ` Eric Wong
2007-05-13  7:53   ` Eric Wong [this message]
2007-05-13 13:22   ` Martin Eisenhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070513075316.GA1168@muzzle \
    --to=normalperson@yhbt.net \
    --cc=aroben@apple.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=martin.eisenhardt@mneisen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).