git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Yann Dirson <ydirson@altern.org>
Cc: "Karl Hasselström" <kha@treskal.com>,
	"Catalin Marinas" <catalin.marinas@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] Document patch syntax.
Date: Sun, 13 May 2007 04:27:10 -0400	[thread overview]
Message-ID: <20070513082710.GA12712@coredump.intra.peff.net> (raw)
In-Reply-To: <20070512143827.GE16903@nan92-1-81-57-214-146.fbx.proxad.net>

On Sat, May 12, 2007 at 04:38:27PM +0200, Yann Dirson wrote:

> > > +Patches in the stack are identified with a short name, which must be
> > > +unique in the stack.
> > s/a short name/short names/, maybe.
> Hm, not sure how that would play with the end of the sentence - any
> native english speaker with an opinion ?

Karl's version is more correct (but your version might be used by many
native speakers). The second half of the sentence is correct because
'must' conjugates the same for singular and plural use; however, it
might be more clear to say "...short name, each of which must be unique
in the stack."

> No strong opinion here.  However, that makes me think we should
> probably use guideline for the docs - here comes the question of which
> convention to use when refering to the user.  Do we address her
> directly ("you"), indirectly ("the user", "her" - don't remember where
> the "female user" use comes from, but we could maybe follow this),
> even more indirectly ("one"), or any other way ?

Most of the git docs already use direct address (just grep for 'you' in
Documentation). It's less formal, but it tends to read much more easily.

-Peff

      parent reply	other threads:[~2007-05-13  8:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-12 12:07 [PATCH] Document patch syntax Yann Dirson
2007-05-12 13:56 ` Karl Hasselström
2007-05-12 14:38   ` Yann Dirson
2007-05-12 18:32     ` Karl Hasselström
2007-05-12 19:02       ` Junio C Hamano
2007-05-13  8:28         ` Jeff King
2007-05-13  8:27     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070513082710.GA12712@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    --cc=ydirson@altern.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).