From: Jakub Narebski <jnareb@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org, cworth@cworth.org
Subject: Re: [PATCH] git-add: allow path limiting with -u
Date: Sun, 13 May 2007 12:35:24 +0200 [thread overview]
Message-ID: <200705131235.25281.jnareb@gmail.com> (raw)
In-Reply-To: <20070512064159.GA7471@coredump.intra.peff.net>
On Sat, 12 May 2007, Jeff King wrote:
> Rather than updating all working tree paths, we limit
> ourselves to paths listed on the command line.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> This turned out to be quite easy to implement. Patch is slightly larger
> than necessary due to removing _all_ from the variable names, but I
> think that better expresses the new functionality.
>
> I'm not sure that the documentation needs updated at all; I had just
> assumed after reading it that 'git-add -u foo' would DWIM.
Do git-add *needs* path specifier (even if it is '.') also for `-u'?
The changes in documentation were to reflect that `-u' is incompatibile
with explicit paths, or that `-u' does not require explicit paths
contrary to git-add without `-u'.
The fact that "add --interactive does not take any parameters" is
separate issue (which, accidentally, was adressed in the same patch).
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2007-05-13 23:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 6:42 [PATCH] git-add: allow path limiting with -u Jeff King
2007-05-12 7:13 ` Junio C Hamano
2007-05-13 10:35 ` Jakub Narebski [this message]
2007-05-14 0:39 ` Jeff King
2007-05-14 0:50 ` Jakub Narebski
2007-05-14 0:49 ` Jeff King
2007-05-14 1:26 ` Junio C Hamano
2007-05-14 0:42 ` Jeff King
2007-05-14 1:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705131235.25281.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=cworth@cworth.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).