Re: [PATCH] Use $Id$ as the ident attribute keyword rather than $ident$ to be consistent with other VCSs

[Andy Parkins <andyparkins@gmail.com>]

On Monday 2007, May 14, Junio C Hamano wrote:

> My take when I did the $ident$ stuff on this issue was quite the
> opposite.  CVS "$Id$" means quite a different thing (pathname,

You're right, but I think it's intended as a unique identifier rather 
than that specific information.  If that were wanted by a CVS/SVN user 
they would have used $Author$, $Rev$, $Date$, etc.  $Id$ to me was just 
some way of identifying the file its in uniquely - the fact that git 
has a much better way of doing that is a bonus, and is exactly right 
for $Id$ IMHO.

> per-file revision number, date, and status) and it would not be
> right to overwrite it with $ident$ which does not record any of
> those "context sensitive" information.

It would be perfectly correct to overwrite it, as in the repository 
version none of that information is present, and even if it wasn't, as 
we've discussed at length, it's all meaningless in a git context 
anyway - the best thing that you could do for it _is_ overwrite it.

> I did not think other systems making that mistake was not an
> excuse for us to do so, but on the other hand, if the users of
> those other systems are happy to lose the information from CVS
> then perhaps the users do want $Id$.

As I said, there is no information in that field when we import from 
CVS/SVN - the repository versions are stored with the fields 
collapsed - so you are not overwriting anything, and therefore not 
losing information.

> Obviously I do not care much about this feature and I have not
> look at Andy's patch too deeply yet, but in any case I think the
> inverse conversion needs to be modified to match it, if it
> hasn't been done so.

I believe I did the inverse conversion as well.  It's only rough, in the  
end I don't care much either way - I've already converted everything of 
mine to git so it affects me not at all.  I offer it only as a 
suggestion for imports from other repositories.



Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com