git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: Opinions on bug fix organisation
Date: Wed, 16 May 2007 11:38:28 +0100	[thread overview]
Message-ID: <200705161138.30134.andyparkins@gmail.com> (raw)

Hello,

This is not so much a question about git, but more about history organisation.  
I'm undecided on the best way to deal with bug fix history.

Imagine this situation:

 * -- * -- B -- * -- * -- *

"B" is a commit that introduced a feature and a bug, that bug is present 
forever more in history (which I think is good - history is history).  I've 
pushed the repository to the rest of the developers in the meantime, so there 
is no editing "B" and doing some rebase magic.

Now, I want to make a commit that fixes that bug.  These are the options:

 * -- * -- B -- * -- * -- * -- F

 or

 * -- * -- B -- * -- * -- * -- M
            \                 /
             --------------- F

That is - just commit a fix or, commit the fix, "F", directly on "B" then 
merge that fix back to HEAD with "M".

I quite like option 2 because it records intent - i.e. "I wish I could have 
gone back and changed this revision, but I can't", but it makes a more 
complicated history.

What do people think?



Andy

-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com

             reply	other threads:[~2007-05-16 10:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-16 10:38 Andy Parkins [this message]
2007-05-16 14:46 ` Opinions on bug fix organisation Brian Gernhardt
2007-05-16 17:55 ` Junio C Hamano
2007-05-16 21:20   ` Andy Parkins
2007-05-16 21:38     ` Shawn O. Pearce
2007-05-18  8:11     ` Johannes Sixt
2007-05-16 21:51 ` Martin Langhoff
2007-05-18 19:50 ` Jan Hudec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705161138.30134.andyparkins@gmail.com \
    --to=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).