From: "Shawn O. Pearce" <spearce@spearce.org>
To: Petr Baudis <pasky@suse.cz>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] git-gui: Build even if tclsh is not available
Date: Wed, 16 May 2007 22:18:58 -0400 [thread overview]
Message-ID: <20070517021858.GY3141@spearce.org> (raw)
In-Reply-To: <20070517021448.24022.8282.stgit@rover>
Petr Baudis <pasky@suse.cz> wrote:
> As of now, git fails to build with default config if tclsh is not
> available, thus requiring manual config tweaking just because of some
> optimizations done at build time; this is a needless hassle when building
> git on any kind of a server.
>
> This patch makes git-gui's build process to handle this gracefully; unless
> TCL_PATH is explicitly set, if tclsh cannot be executed only a warning is
> printed and the build goes on. I have tested this only on that server with
> no tclsh, but hopefully it shouldn't break the build process with tclsh
> available either.
>
> Version 2, sorry - the previous version of the patch had the install hunk
> missing. And apologies for the duplicate submission... :-)
>
> Signed-off-by: Petr Baudis <pasky@suse.cz>
> ---
>
> Makefile | 8 +++++---
> git-gui/Makefile | 4 ++--
> 2 files changed, 7 insertions(+), 5 deletions(-)
I have a couple of problems with the patch as-is. The first is
of course that the patch needs to be split into two; one patch for
the git-gui subdirectory itself and one for git.git.
My other problem is
> ifeq ($(findstring $(MAKEFLAGS),s),s)
> @@ -92,7 +92,7 @@ install: all
> $(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'
> $(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)
> $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(libdir_SQ)'
> - $(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)'
> + [ ! -e lib/tclIndex ] || $(INSTALL) -m644 lib/tclIndex '$(DESTDIR_SQ)$(libdir_SQ)'
> $(foreach p,$(ALL_LIBFILES), $(INSTALL) -m644 $p '$(DESTDIR_SQ)$(libdir_SQ)' ;)
git-gui won't work if lib/tclIndex is missing or invalid. So not
installing it means we should just disable git-gui entirely.
--
Shawn.
next prev parent reply other threads:[~2007-05-17 2:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 2:06 [PATCH] git-gui: Build even if tclsh is not available Petr Baudis
2007-05-17 2:14 ` Petr Baudis
2007-05-17 2:18 ` Shawn O. Pearce [this message]
2007-05-17 2:36 ` Petr Baudis
2007-05-17 2:49 ` Shawn O. Pearce
2007-05-17 22:16 ` Shawn O. Pearce
-- strict thread matches above, loose matches on Subject: below --
2007-05-17 2:04 Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070517021858.GY3141@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).