From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings
Date: Thu, 17 May 2007 13:25:11 +0200 [thread overview]
Message-ID: <20070517112510.GM4489@pasky.or.cz> (raw)
In-Reply-To: <7vabw4ccy5.fsf@assigned-by-dhcp.cox.net>
On Thu, May 17, 2007 at 06:05:06AM CEST, Junio C Hamano wrote:
> Petr Baudis <pasky@suse.cz> writes:
>
> > On Fri, Apr 27, 2007 at 06:43:53PM CEST, Petr Baudis wrote:
> >> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> >> index b67ce41..b51103e 100755
> >> --- a/gitweb/gitweb.perl
> >> +++ b/gitweb/gitweb.perl
> >> @@ -1057,6 +1058,7 @@ sub git_get_project_description {
> >> open my $fd, "$projectroot/$path/description" or return undef;
> >> my $descr = <$fd>;
> >> close $fd;
> >> + $descr or return undef;
> >> chomp $descr;
> >> return $descr;
> >> }
> >
> > It looks like this hunk has been skipped...?
>
> It is more like the whole messages was missed, and then 198a2a8a
> and others tried to do the same thing but missed this one.
Oh, aha - I thought that it was applied when you replied "thanks"...
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
-- Samuel Beckett
prev parent reply other threads:[~2007-05-17 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 16:43 [PATCH] gitweb: Fix few 'use of undefined value' warnings Petr Baudis
2007-04-29 6:49 ` Junio C Hamano
2007-05-17 1:32 ` Petr Baudis
2007-05-17 4:05 ` Junio C Hamano
2007-05-17 11:25 ` Petr Baudis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070517112510.GM4489@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).