[PATCH] gitweb: Fix few 'use of undefined value' warnings

[PATCH] gitweb: Fix few 'use of undefined value' warnings

[Petr Baudis]

Signed-off-by: Petr Baudis <pasky@suse.cz>
---

 gitweb/gitweb.perl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index b67ce41..b51103e 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1038,6 +1038,7 @@ sub git_get_hash_by_path {
 		or die_error(undef, "Open git-ls-tree failed");
 	my $line = <$fd>;
 	close $fd or return undef;
+	$line or return undef;
 
 	#'100644 blob 0fa3f3a66fb6a137f6ec2c19351ed4d807070ffa	panic.c'
 	$line =~ m/^([0-9]+) (.+) ([0-9a-fA-F]{40})\t/;
@@ -1057,6 +1058,7 @@ sub git_get_project_description {
 	open my $fd, "$projectroot/$path/description" or return undef;
 	my $descr = <$fd>;
 	close $fd;
+	$descr or return undef;
 	chomp $descr;
 	return $descr;
 }
@@ -1208,6 +1210,7 @@ sub git_get_last_activity {
 	     'refs/heads') or return;
 	my $most_recent = <$fd>;
 	close $fd or return;
+	$most_recent or return;
 	if ($most_recent =~ / (\d+) [-+][01]\d\d\d$/) {
 		my $timestamp = $1;
 		my $age = time - $timestamp;

Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings

[Junio C Hamano]

thanks.

Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings

[Petr Baudis]

On Fri, Apr 27, 2007 at 06:43:53PM CEST, Petr Baudis wrote:
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index b67ce41..b51103e 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1057,6 +1058,7 @@ sub git_get_project_description {
>  	open my $fd, "$projectroot/$path/description" or return undef;
>  	my $descr = <$fd>;
>  	close $fd;
> +	$descr or return undef;
>  	chomp $descr;
>  	return $descr;
>  }

It looks like this hunk has been skipped...?

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett

Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings

[Junio C Hamano]

Petr Baudis <pasky@suse.cz> writes:

> On Fri, Apr 27, 2007 at 06:43:53PM CEST, Petr Baudis wrote:
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index b67ce41..b51103e 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -1057,6 +1058,7 @@ sub git_get_project_description {
>>  	open my $fd, "$projectroot/$path/description" or return undef;
>>  	my $descr = <$fd>;
>>  	close $fd;
>> +	$descr or return undef;
>>  	chomp $descr;
>>  	return $descr;
>>  }
>
> It looks like this hunk has been skipped...?

It is more like the whole messages was missed, and then 198a2a8a
and others tried to do the same thing but missed this one.

Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings

[Petr Baudis]

On Thu, May 17, 2007 at 06:05:06AM CEST, Junio C Hamano wrote:
> Petr Baudis <pasky@suse.cz> writes:
> 
> > On Fri, Apr 27, 2007 at 06:43:53PM CEST, Petr Baudis wrote:
> >> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> >> index b67ce41..b51103e 100755
> >> --- a/gitweb/gitweb.perl
> >> +++ b/gitweb/gitweb.perl
> >> @@ -1057,6 +1058,7 @@ sub git_get_project_description {
> >>  	open my $fd, "$projectroot/$path/description" or return undef;
> >>  	my $descr = <$fd>;
> >>  	close $fd;
> >> +	$descr or return undef;
> >>  	chomp $descr;
> >>  	return $descr;
> >>  }
> >
> > It looks like this hunk has been skipped...?
> 
> It is more like the whole messages was missed, and then 198a2a8a
> and others tried to do the same thing but missed this one.

Oh, aha - I thought that it was applied when you replied "thanks"...

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett