git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Fredrik Kuivinen <frekui@gmail.com>
Subject: Re: [PATCH] gitweb: Incremental blame
Date: Fri, 18 May 2007 17:26:34 +0200	[thread overview]
Message-ID: <20070518152634.GY4489@pasky.or.cz> (raw)
In-Reply-To: <20070518151502.27621.36135.stgit@rover>

On Fri, May 18, 2007 at 05:15:02PM CEST, Petr Baudis wrote:
> Compared to the original patch, this one works with pathinfo-ish URLs as
> well, and should play well with non-javascript browsers as well (the HTML
> points to the blame action, while javascript code rewrites the links to use
> the blame_incremental action; it is somewhat hackish but I couldn't think
> of a better solution).

To make it more clear, the additional changes in this patch are really
totally trivial (except the link rewriting javascript code, which is
rather simple too and I spent only two happy hours of my life debugging
it) - maybe I should've kept Fredrik signed off and maybe even the patch
author and add just my signoff. I'm not really sure how the procedures
should work here.

-- 
		Petr "Pasky the I HATE THE
			!@#*($!*(^%@#*$233.. JAVASCRIPT!!!!!!!!" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett

  reply	other threads:[~2007-05-18 15:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-18 15:15 [PATCH] gitweb: Incremental blame Petr Baudis
2007-05-18 15:26 ` Petr Baudis [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-03-04 16:40 Fredrik Kuivinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070518152634.GY4489@pasky.or.cz \
    --to=pasky@suse.cz \
    --cc=frekui@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).