Git development
 help / color / mirror / Atom feed
From: Johannes Sixt <johannes.sixt@telecom.at>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, j.sixt@eudaptics.com
Subject: Re: git log -S problem
Date: Mon, 21 May 2007 07:27:23 +0200	[thread overview]
Message-ID: <200705210727.23898.johannes.sixt@telecom.at> (raw)
In-Reply-To: <7vy7jjjjdm.fsf@assigned-by-dhcp.cox.net>

On Sunday 20 May 2007 23:05, Junio C Hamano wrote:
> Johannes Sixt <johannes.sixt@telecom.at> writes:
> > I had expected that the set of commits found by the second search string
> > are a proper superset of those found by the first one. What's wrong here?
> > Why does a search for 'merge-base' not find occurences of
> > 'builtin-merge-base'?
>
> 71dfbf224 removes one line that has "git-merge-base$X" and adds
> one line that has "builtin-merge-base.o".  If you count the
> number of occurences of substring "builtin-merge-base" in the
> preimage and the postimage, you see one addition.  If you count
> the same for substring "merge-base", the net difference is 0.

But is this how -S is *designed* to work? 

Hm, the documentation says (diff-options.txt):

-S<string>::
	Look for differences that contain the change in <string>.

which can be interpreted both to match my expectations as well as the current 
implementation.

-- Hannes

  reply	other threads:[~2007-05-21  5:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-20 19:15 git log -S problem Johannes Sixt
2007-05-20 21:05 ` Junio C Hamano
2007-05-21  5:27   ` Johannes Sixt [this message]
2007-05-21  7:34     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705210727.23898.johannes.sixt@telecom.at \
    --to=johannes.sixt@telecom.at \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@eudaptics.com \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox