From: Martin Waitz <tali@admingilde.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Torgil Svensson <torgil.svensson@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] rename dirlink to gitlink.
Date: Tue, 22 May 2007 07:59:39 +0200 [thread overview]
Message-ID: <20070522055939.GG5412@admingilde.org> (raw)
In-Reply-To: <7vodkdbvmk.fsf@assigned-by-dhcp.cox.net>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
hoi :)
On Mon, May 21, 2007 at 04:32:51PM -0700, Junio C Hamano wrote:
> As an internal symbol, S_IFDIRLNK makes _much_ more sense than
> S_IFGITLINK, exactly because it is a mixture of S_IFDIR and
> S_IFLNK.
But then we also should be consequent and rename the entire
low-level plumbing to dirlink. I don't see a reason to keep
both.
For me the S_ macro names are about the file type which is represented
by them. The fact that dirlinks/gitlinks are represented as
DIR + LNK is nice but not so important that we have to name the
macro that way.
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-05-22 5:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 20:08 [PATCH] rename dirlink to gitlink Martin Waitz
2007-05-21 23:12 ` Torgil Svensson
2007-05-21 23:32 ` Junio C Hamano
2007-05-22 5:59 ` Martin Waitz [this message]
2007-05-22 6:19 ` Junio C Hamano
2007-05-22 11:39 ` [PATCH] rename gitlink to dirlink Martin Waitz
2007-05-22 11:53 ` [PATCH] rename dirlink to gitlink Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070522055939.GG5412@admingilde.org \
--to=tali@admingilde.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torgil.svensson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).