From: "Shawn O. Pearce" <spearce@spearce.org>
To: Simon Hausmann <simon@lst.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fast-import: Fix crash when referencing already existing objects
Date: Wed, 23 May 2007 23:44:15 -0400 [thread overview]
Message-ID: <20070524034415.GF28023@spearce.org> (raw)
In-Reply-To: <200705232301.49667.simon@lst.de>
Simon Hausmann <simon@lst.de> wrote:
> Commit a5c1780a0355a71b9fb70f1f1977ce726ee5b8d8 sets the pack_id of existing
> objects to MAX_PACK_ID. When the same object is referenced later again it is
> found in the local object hash. With such a pack_id fast-import should not try
> to locate that object in the newly created pack(s).
Thanks, that was a _really_ nasty bug. :-(
Turns out there's more cases. Such as if we reload a mark table of
commits (--import-marks) and then try to create a branch from them.
The existing commit will also have a pack_id of MAX_PACK_ID and
we'll go right into the same corruption you saw and fixed here.
I will be pushing your two patches and my additional fixup to
my maint branch tonight.
--
Shawn.
prev parent reply other threads:[~2007-05-24 3:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 21:01 [PATCH] fast-import: Fix crash when referencing already existing objects Simon Hausmann
2007-05-24 3:44 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524034415.GF28023@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=simon@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).