From: Martin Waitz <tali@admingilde.org>
To: Sam Vilain <sam@vilain.net>
Cc: Sam Vilain <sam.vilain@catalyst.net.nz>,
Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org
Subject: Re: [PATCH] Make sure an autogenerated version has at least four parts
Date: Fri, 25 May 2007 11:47:43 +0200 [thread overview]
Message-ID: <20070525094743.GO5412@admingilde.org> (raw)
In-Reply-To: <46563CE1.9020007@vilain.net>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
hoi :)
On Fri, May 25, 2007 at 01:33:21PM +1200, Sam Vilain wrote:
> Martin Waitz wrote:
> > On Mon, May 21, 2007 at 02:52:21PM +1200, Sam Vilain wrote:
> >> Otherwise, a custom "v1.5.2.42.gd00b" is considered newer than a
> >> "v1.5.2.1.69.gcafe".
> >
> > or just use git describe output without replacing "-" with "."?
>
> dpkg uses "-" in version numbers for its own uses - to delimit the
> packager's packaging version from the software version.
But you can also have "-" in the upstream version without problems.
Only the last "-" is used as deliminator and therefore the Debian
version part must not contain a "-"; it's no problem for the upstream
part.
> The change I posted keeps original behaviour - just fills out the
> .0's.
> Perhaps the munging should go in git-describe instead?
If we want to be able to separate the software version as it is defined
by the project maintainer from the additional Git information we should
do so with a clear separator, not by changing the software version.
Maybe have some Makefile magic which creates a nice version,
but interpreting and changing the tagged version in git-describe sounds
wrong to me.
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2007-05-25 9:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 2:52 [PATCH] Make sure an autogenerated version has at least four parts Sam Vilain
2007-05-21 7:36 ` Martin Waitz
2007-05-21 19:57 ` Jan Hudec
2007-05-21 20:06 ` Martin Waitz
2007-05-25 1:33 ` Sam Vilain
2007-05-25 1:42 ` Sam Vilain
2007-05-25 9:47 ` Martin Waitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525094743.GO5412@admingilde.org \
--to=tali@admingilde.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=sam.vilain@catalyst.net.nz \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).