From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: Joshua N Pritikin <jpritikin@pobox.com>
Subject: Re: [PATCH] Don't allow newlines to occur in $Id:$ collapse
Date: Fri, 25 May 2007 14:50:53 +0100 [thread overview]
Message-ID: <200705251451.00999.andyparkins@gmail.com> (raw)
In-Reply-To: <20070525132800.GH6667@always.joy.eth.net>
On Friday 2007 May 25, Joshua N Pritikin wrote:
> That's better but I would error out instead of silently ignoring it.
> Your choice.
We can't error out on checking a file out - that file is in the repository
already, if it's got problems - so be it, it's got to be possible to check it
out.
One could even argue that it's not actually an error, if we define keywords to
be such that they are not allowed to contain newlines, then the fact that
someone has written "$Id:" in their file, with no closing "$" just means that
it's not a keyword; and like every other non-keyword bit of data in the file
it should be left untouched.
Andy
--
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
next prev parent reply other threads:[~2007-05-25 13:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 10:50 [PATCH] Fix mishandling of $Id$ expanded in the repository copy in convert.c Andy Parkins
2007-05-25 10:58 ` Joshua N Pritikin
2007-05-25 13:12 ` Andy Parkins
2007-05-25 13:13 ` [PATCH] Don't allow newlines to occur in $Id:$ collapse Andy Parkins
2007-05-25 13:28 ` Joshua N Pritikin
2007-05-25 13:47 ` Nicolas Pitre
2007-05-25 13:50 ` Andy Parkins [this message]
2007-05-25 14:40 ` Joshua N Pritikin
2007-05-26 8:09 ` [PATCH] Fix mishandling of $Id$ expanded in the repository copy in convert.c Junio C Hamano
2007-05-26 9:12 ` Andy Parkins
2007-05-26 19:05 ` Junio C Hamano
2007-05-27 10:50 ` Andy Parkins
2007-05-27 10:52 ` [PATCH] Add test case for $Id$ expanded in the repository Andy Parkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705251451.00999.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=jpritikin@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).