From: Martin Waitz <tali@admingilde.org>
To: skimo@liacs.nl
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>,
Alex Riesen <raa.lkml@gmail.com>
Subject: Re: [PATCH 2/3] entry.c: checkout available submodules
Date: Fri, 25 May 2007 23:31:03 +0200 [thread overview]
Message-ID: <20070525213103.GA8361@admingilde.org> (raw)
In-Reply-To: <1180127233893-git-send-email-skimo@liacs.nl>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
hoi :)
On Fri, May 25, 2007 at 11:07:12PM +0200, skimo@liacs.nl wrote:
> create mode 100644 submodules.c
> create mode 100644 submodules.h
I think the list tends to prefer subproject over submodule.
> @@ -193,9 +220,8 @@ int checkout_entry(struct cache_entry *ce, const struct checkout *state, char *t
> */
> unlink(path);
> if (S_ISDIR(st.st_mode)) {
> - /* If it is a gitlink, leave it alone! */
> if (S_ISGITLINK(ntohl(ce->ce_mode)))
> - return 0;
> + return checkout_submodule(ce, path, state);
> if (!state->force)
> return error("%s is a directory", path);
> remove_subtree(path);
I think the call to checkout_submodule should be moved to write_entry,
to keep it in line with the other mode types.
Aside from that I really like it :-)
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-05-25 21:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 21:07 [PATCH 1/3] run-command: optionally clear git environment skimo
2007-05-25 21:07 ` [PATCH 2/3] entry.c: checkout available submodules skimo
2007-05-25 21:31 ` Martin Waitz [this message]
2007-05-25 21:42 ` Sven Verdoolaege
2007-05-25 22:19 ` Martin Waitz
2007-05-25 23:06 ` Junio C Hamano
2007-05-25 21:07 ` [PATCH 3/3] test for simple submodule checkout support skimo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525213103.GA8361@admingilde.org \
--to=tali@admingilde.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
--cc=skimo@liacs.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).