From: "Shawn O. Pearce" <spearce@spearce.org>
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] always start looking up objects in the last used pack first
Date: Thu, 31 May 2007 01:02:11 -0400 [thread overview]
Message-ID: <20070531050211.GV7044@spearce.org> (raw)
In-Reply-To: <alpine.LFD.0.99.0705302152180.11491@xanadu.home>
Nicolas Pitre <nico@cam.org> wrote:
> Pack Sort w/o this patch w/ this patch
> -------------------------------------------------------------
> recent objects last 26.4s 20.9s
> recent objects first 24.9s 18.4s
Looks pretty good.
> + next:
> + if (p == last_found)
> + p = packed_git;
> + else
> + p = p->next;
> + if (p == last_found)
> + p = p->next;
> + } while (p);
So if we didn't find the object in the pack that we found the
last object in, we restart our search with the most recent pack?
Why not just go to p->next and loop around? If we missed in this
pack and the packs are sorted by recency, wouldn't we want to just
search the next pack?
--
Shawn.
next prev parent reply other threads:[~2007-05-31 5:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 2:48 [PATCH] always start looking up objects in the last used pack first Nicolas Pitre
2007-05-31 3:24 ` Nicolas Pitre
2007-05-31 5:02 ` Shawn O. Pearce [this message]
2007-05-31 15:39 ` Nicolas Pitre
2007-06-02 15:00 ` Dana How
2007-06-02 14:53 ` Dana How
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531050211.GV7044@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).