git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: git@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Subject: Improved git-gui blame viewer
Date: Sat, 2 Jun 2007 00:17:23 -0400	[thread overview]
Message-ID: <20070602041723.GD7044@spearce.org> (raw)

A long time ago Linus Torvalds <torvalds@linux-foundation.org> wrote:
> 
> On Sun, 18 Mar 2007, Shawn O. Pearce wrote:
> > Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > > 
> > > Of course, the git gui blame colorization is clearly done by somebody who 
> > > is still actively popping LSD with both fists and didn't realize that the 
> > > 60's are long done, but that's another issue.
> > 
> > git-gui is open source.  I'd be happy to take a patch.  Or,
> > since that is horribly messy Tcl/Tk code, just a better color
> > suggestion. :-)
> 
> I would suggest:
> 
>  - some special color for "currently selected" (which defaults to being 
>    the first one coming out of the blame thing, of course). 
> 
>    I'd suggest "black text on pale green background", but that may be just 
>    me.
> 
>  - some *stable* graduated color for the rest. I don't think it 
>    necessarily needs to be "older" vs "newer", and in fact I'd suggest 
>    just two slightly different shades of gray for the background - just 
>    pick alternating shades for each blame entry that comes in (and leave 
>    un-blamed lines white).

I finally got the git-gui code to the point where cleaning up the
user interface was possible without sending myself to the nut house.

I tried out Linus' suggestions for coloring, and I like them.  Enough
that they are now sitting in my `pu` branch on repo.or.cz/git-gui.git.

There's also a whole slew of other improvements to the blame viewer,
like being able to dig through history by clicking on commit ids,
and tooltips when you mouse over a region of the file.

Behavior on Windows is actually quite good; its less so on Mac
OS X.  I'm fighting Tk there a little bit more than I should be.
Untested on Linux, so I'd love to hear some feedback on it.

  git://repo.or.cz/git-gui.git      pu
  http://repo.or.cz/r/git-gui.git   pu
 
-- 
Shawn.

             reply	other threads:[~2007-06-02  4:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02  4:17 Shawn O. Pearce [this message]
2007-06-02 10:44 ` Improved git-gui blame viewer Matthijs Melchior
2007-06-04  6:07   ` Shawn O. Pearce
2007-06-04  7:38     ` Martin Waitz
2007-06-04  8:21       ` Shawn O. Pearce
2007-06-04  8:48         ` Martin Waitz
2007-06-04 21:26     ` Matthijs Melchior
2007-06-05  4:28       ` Shawn O. Pearce
2007-06-05 21:47         ` Matthijs Melchior
2007-06-04 16:10 ` Alex Riesen
2007-06-05  4:38   ` Shawn O. Pearce
2007-06-05 10:36     ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070602041723.GD7044@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).