From: Matthias Lederhofer <matled@gmx.net>
To: Martin Waitz <tali@admingilde.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Support environment variables in config file
Date: Mon, 4 Jun 2007 10:44:11 +0200 [thread overview]
Message-ID: <20070604084411.GA17622@moooo.ath.cx> (raw)
In-Reply-To: <20070604072707.GE16637@admingilde.org>
Martin Waitz <tali@admingilde.org> wrote:
> Do you think the approach is ok?
Looks fine from the reading part. Up to now
$ git config "$key" "$value" &&
[ "$value" = "$(git config "$key")" ] &&
echo true
will echo true for all values (at least from the things I tried with
", \ and \n). When interpreting $VAR this changes. I dunno if there
are any programs out there that rely on the fact that the value you
get out of the config is exactly the same as you have put in.
> Can you see other examples where we may need $VAR support?
> Or would everybody be happy with support for ~/ in filenames?
In my config I don't even use the path to my home directory anywhere
and spontaneously I can't think of any config option for which I'd use
an environment variable as value.
next prev parent reply other threads:[~2007-06-04 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 22:37 [PATCH] Support environment variables in config file Martin Waitz
2007-06-04 5:34 ` Matthias Lederhofer
2007-06-04 7:27 ` Martin Waitz
2007-06-04 8:44 ` Matthias Lederhofer [this message]
2007-06-04 15:57 ` Johannes Schindelin
2007-06-04 17:47 ` Martin Waitz
2007-06-04 17:59 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070604084411.GA17622@moooo.ath.cx \
--to=matled@gmx.net \
--cc=git@vger.kernel.org \
--cc=tali@admingilde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).