From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Herland Subject: Re: [PATCH] fsck: do not crash on tag objects which do not contain an empty line Date: Fri, 08 Jun 2007 01:08:49 +0200 Message-ID: <200706080108.50042.johan@herland.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7BIT Cc: Johannes Schindelin , gitster@pobox.com To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Fri Jun 08 01:09:13 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1HwR6O-0003bo-S8 for gcvg-git@gmane.org; Fri, 08 Jun 2007 01:09:13 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932131AbXFGXJG (ORCPT ); Thu, 7 Jun 2007 19:09:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933204AbXFGXJG (ORCPT ); Thu, 7 Jun 2007 19:09:06 -0400 Received: from [84.208.20.33] ([84.208.20.33]:47996 "EHLO smtp.getmail.no" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932131AbXFGXJE (ORCPT ); Thu, 7 Jun 2007 19:09:04 -0400 Received: from pmxchannel-daemon.no-osl-m323-srv-009-z2.isp.get.no by no-osl-m323-srv-009-z2.isp.get.no (Sun Java System Messaging Server 6.2-7.05 (built Sep 5 2006)) id <0JJA00K0BGB3ZX00@no-osl-m323-srv-009-z2.isp.get.no> for git@vger.kernel.org; Fri, 08 Jun 2007 01:09:03 +0200 (CEST) Received: from smtp.getmail.no ([10.5.16.1]) by no-osl-m323-srv-009-z2.isp.get.no (Sun Java System Messaging Server 6.2-7.05 (built Sep 5 2006)) with ESMTP id <0JJA00HPVGAQH200@no-osl-m323-srv-009-z2.isp.get.no> for git@vger.kernel.org; Fri, 08 Jun 2007 01:08:50 +0200 (CEST) Received: from alpha.herland ([84.210.6.167]) by no-osl-m323-srv-004-z1.isp.get.no (Sun Java System Messaging Server 6.2-7.05 (built Sep 5 2006)) with ESMTP id <0JJA00KTMGAQZT10@no-osl-m323-srv-004-z1.isp.get.no> for git@vger.kernel.org; Fri, 08 Jun 2007 01:08:50 +0200 (CEST) In-reply-to: Content-disposition: inline User-Agent: KMail/1.9.7 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On Friday 08 June 2007, Johannes Schindelin wrote: > > The first empty line in a tag object separates the header from the > message. If the tag object has no empty line, do not crash, but > complain loudly instead. Aren't tag objects _required_ to have an empty line separating the headers from the body? At least I wrote the new tag code with that assumption in mind. Could this be related to the "error: char103: premature end of data" you're seeing? ...Johan -- Johan Herland, www.herland.net