From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Fix push with refspecs containing wildcards
Date: Fri, 8 Jun 2007 11:13:32 +0200 [thread overview]
Message-ID: <20070608091332.GA2429@steel.home> (raw)
In-Reply-To: <7vodjqlwnc.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano, Fri, Jun 08, 2007 09:42:47 +0200:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Sending a fix is a good thing, but whenever doing one, could
> > people please also do a testcase that demonstrates the original
> > bug, and also a demonstration that the fix does not introduce
> > regression?
Sorry. I actually have a test script I used to develop the fix,
but somehow missed to send it.
> > For this one, obviously a test for push that uses such wildcard
> > ref is needed but at the same time we would want a test for push
> > that does _not_ use a wildcard, fetch that uses a wildcard, and
> > a fetch that does not use a wildcard.
>
> How about this?
> ---
>
> t/t5516-fetch-push.sh | 82 +++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 82 insertions(+), 0 deletions(-)
>
Gratefully-Acked-by: Alex Riesen <raa.lkml@gmail.com>
prev parent reply other threads:[~2007-06-08 9:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 22:53 git-send-pack: broken handling of ref specs with wildcards Alex Riesen
2007-06-07 22:56 ` Johannes Schindelin
2007-06-08 6:33 ` Junio C Hamano
2007-06-08 18:47 ` Daniel Barkalow
2007-06-07 23:43 ` [PATCH] Fix push with refspecs containing wildcards Alex Riesen
2007-06-08 6:38 ` Junio C Hamano
2007-06-08 7:42 ` Junio C Hamano
2007-06-08 9:13 ` Alex Riesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608091332.GA2429@steel.home \
--to=raa.lkml@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).