From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, gitster@pobox.com
Subject: Re: [PATCH] fsck: do not crash on tag objects which do not contain an empty line
Date: Fri, 8 Jun 2007 09:32:03 +0100 [thread overview]
Message-ID: <200706080932.05098.andyparkins@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0706072338260.4046@racer.site>
On Thursday 2007 June 07, Johannes Schindelin wrote:
> + error("tag %s does not contain any tag?", refname);
Seems a bad error message to me. Also, why is it a question?
git: tag does not contain a tag
user: WTF?
Perhaps, "The annotated tag, %s, does not contain a message", or similar?
Also - is this really something that should be complained about? I'm
wondering why it is important that tag objects contain a message? For
example, tagging a release as v1.0.0 - it's important to record who tagged
it, and when it was tagged, but I can certainly envisage there not being a
message to go with it. Most tags in the git repository are just a repeat of
the tag name in the message.
Andy
--
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
prev parent reply other threads:[~2007-06-08 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 22:40 [PATCH] fsck: do not crash on tag objects which do not contain an empty line Johannes Schindelin
2007-06-07 23:08 ` Johan Herland
2007-06-07 23:13 ` Johannes Schindelin
2007-06-07 23:28 ` Johan Herland
2007-06-07 23:38 ` Johannes Schindelin
2007-06-08 2:04 ` Nicolas Pitre
2007-06-08 2:14 ` Johan Herland
2007-06-08 5:17 ` Junio C Hamano
2007-06-08 5:30 ` Johannes Schindelin
2007-06-08 8:32 ` Andy Parkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706080932.05098.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).