Re: [PATCH 2/4] Introduce optional "keywords" on tag objects

[Johan Herland <johan@herland.net>]

On Sunday 10 June 2007, Johannes Schindelin wrote:
> Hi,
> 
> On Sun, 10 Jun 2007, Johan Herland wrote:
> 
> > +	/* Verify the keywords: disallow ctrl chars, spaces and double commas */
> 
> What about Junio's suggestion, making it really strict at first, and only 
> loosening it if we need to? IIRC it was alnum + '_', maybe even '-'.

For now, I couldn't find a good reason why the set of allowed characters
for keywords should be smaller than for the tag name.
Feel free to tighten the set of characters before this makes it into a
release. However, if you do, the same tightening should be considered
for the tag name as well, I guess. Can't see any good reasons for why
one should be tighter than the other.

> And please accept my apologies for my language. Reading some of it, I have 
> to admit that it sounded as harsh as Junio suggested it to be. My only 
> excuse is that I had an unplanned stay at the Paris airport for more than 
> 9 hours (after a night in the plane where I could hardly sleep), so I 
> should really have stayed away from writing emails. But since you 
> addressed your emails to me, I wanted to reply to you as soon as I had the 
> chance to.

Apology accepted. I'm sorry my patch-series-from-hell came at such an
inconvenient time for you. 


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net