git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Lederhofer <matled@gmx.net>
To: Eygene Ryabinkin <rea-git@codelabs.ru>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Teach Makefile to respect external variables: CFLAGS and others.
Date: Wed, 13 Jun 2007 09:42:40 +0200	[thread overview]
Message-ID: <20070613074240.GA12894@moooo.ath.cx> (raw)
In-Reply-To: <20070613071514.GP86872@void.codelabs.ru>

Eygene Ryabinkin <rea-git@codelabs.ru> wrote:
> Junio, Sam, good day.
> 
> Tue, Jun 12, 2007 at 11:07:56PM -0700, Junio C Hamano wrote:
> > I run "make CFLAGS=-O0 -g" all the time.  Also "make CC=echo"
> > seems to "work" as expected ;-).
> > 
> > Care to elaborate what problem you are trying to solve?
> 
> As Sam Ravnborg kindly pointed out, you're using make variables
> and I am trying to give the respect to the environment variables.
> 
> And the real problem is that one (for example, me) can try to
> build Git with the different compiler than CC (gccX or icc, for
> example).  And it is much better for lazy people to do 'export
> CC=whatever' once and then fire make any number of times ;))
> 
> Answering Sam: yes, with my patch it is easier to inherit the
> variables from the environment.  But it is not clear if it is
> good or bad ;))
> 
> But anyway, this patch is only my suggestion, and it can be
> thrown away :)

If you want to fix it for your own checkout of git just put whatever
you like in config.mak.  For example I add -ggdb3 to CFLAGS, set the
prefix variable and add some custom make targets in this file.

  parent reply	other threads:[~2007-06-13  7:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13  5:42 [PATCH] Teach Makefile to respect external variables: CFLAGS and others Eygene Ryabinkin
2007-06-13  6:07 ` Junio C Hamano
2007-06-13  7:15   ` Eygene Ryabinkin
2007-06-13  7:39     ` Junio C Hamano
2007-06-13  7:53       ` Eygene Ryabinkin
2007-06-13  7:42     ` Matthias Lederhofer [this message]
2007-06-13  6:12 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070613074240.GA12894@moooo.ath.cx \
    --to=matled@gmx.net \
    --cc=git@vger.kernel.org \
    --cc=rea-git@codelabs.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).