git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: Gerrit Pape <pape@smarden.org>, Junio C Hamano <junkio@cox.net>,
	428413@bugs.debian.org
Subject: Re: [PATCH] post-receive-email hook: handle order of arguments consistently
Date: Thu, 14 Jun 2007 11:19:17 +0100	[thread overview]
Message-ID: <200706141119.18724.andyparkins@gmail.com> (raw)
In-Reply-To: <20070614090929.31616.qmail@c76df6d65db410.315fe32.mid.smarden.org>

On Thursday 2007 June 14, Gerrit Pape wrote:
> The post-receive-email hook usually gets its arguments through stdin, but
> also supports them to be specified at the command line.  The order of the
> arguments should consistently follow the documentation no matter how they
> are passed to the script.

That wasn't done casually.  It was done so that the same script would work as 
an update hook as well.

I have no objection to the change, as the update hook was not the right place 
for generating emails.  However, it let me use that same update hook on a 
system that did not have a git with support for the post-receive hook.


Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com

  reply	other threads:[~2007-06-14 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-14  9:09 [PATCH] post-receive-email hook: handle order of arguments consistently Gerrit Pape
2007-06-14 10:19 ` Andy Parkins [this message]
2007-08-07 13:58   ` Gerrit Pape
2007-08-07 17:38     ` Andy Parkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706141119.18724.andyparkins@gmail.com \
    --to=andyparkins@gmail.com \
    --cc=428413@bugs.debian.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=pape@smarden.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).