git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sven Verdoolaege <skimo@kotnet.org>
To: Lars Hjemli <hjemli@gmail.com>
Cc: Johannes Sixt <J.Sixt@eudaptics.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] git-submodule: move cloning into a separate function
Date: Sun, 17 Jun 2007 16:38:02 +0200	[thread overview]
Message-ID: <20070617143802.GV955MdfPADPa@greensroom.kotnet.org> (raw)
In-Reply-To: <op.ttf34qd99pspc6@localhost>

On Tue, Jun 05, 2007 at 01:13:28PM +0200, Lars Hjemli wrote:
> +module_clone()
> +{
> +	path=$1
> +	url=$2
> +
> +	# If there already is a directory at the submodule path,
> +	# expect it to be empty (since that is the default checkout
> +	# action) and try to remove it.
> +	# Note: if $path is a symlink to a directory the test will
> +	# succeed but the rmdir will fail. We might want to fix this.
> +	if test -d "$path"
> +	then
> +		rmdir "$path" 2>/dev/null ||
> +		die "Directory '$path' exist, but is neither empty nor a git repository"

What makes you say that '$path' is not a git repository?

skimo

  parent reply	other threads:[~2007-06-17 14:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-05  9:29 [PATCH 0/2] git-submodule: make it easier to use alternate urls Lars Hjemli
     [not found] ` <863f2ca67857bc2d09f46f1a5ef6f653d16d5256.1181034736.git.hjemli@gmail.com>
2007-06-05  9:29   ` [PATCH 1/2] git-submodule: move cloning into a separate function Lars Hjemli
2007-06-05 10:40     ` Johannes Sixt
2007-06-05 11:13       ` Lars Hjemli
2007-06-06  8:55         ` Junio C Hamano
2007-06-17 14:38         ` Sven Verdoolaege [this message]
2007-06-17 15:56           ` Lars Hjemli
2007-06-06  9:13   ` Lars Hjemli
     [not found]   ` <c14730acf8a52a57250303c033ebec09bf960007.1181034736.git.hjemli@gmail.com>
2007-06-05  9:29     ` [PATCH 2/2] git-submodule: clone during update, not during init Lars Hjemli
2007-06-05 11:18       ` Lars Hjemli
2007-06-06  9:13     ` Lars Hjemli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070617143802.GV955MdfPADPa@greensroom.kotnet.org \
    --to=skimo@kotnet.org \
    --cc=J.Sixt@eudaptics.com \
    --cc=git@vger.kernel.org \
    --cc=hjemli@gmail.com \
    --cc=skimo@liacs.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).