From: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
To: gitster@pobox.com
Cc: git@vger.kernel.org
Subject: [PATCH]: tree-walk.h: Warning fix
Date: Tue, 19 Jun 2007 23:11:27 -0300 [thread overview]
Message-ID: <20070619231127.7ffe273b@gnut> (raw)
Code that is using libgit.a, and hence including GIT's headers, may
get this warning:
"""
../tree-walk.h: In function 'tree_entry_len':
../tree-walk.h:25: warning: cast discards qualifiers from pointer target type
../tree-walk.h:25: warning: cast discards qualifiers from pointer target type
"""
This happens because the cast used in tree_entry_len() is discarding
the const qualifier (thanks to Shawn Pearce by noticing this).
Signed-off-by: Luiz Fernando N. Capitulino <lcapitulino@gmail.com>
diff --git a/tree-walk.h b/tree-walk.h
index ee747ab..625198f 100644
--- a/tree-walk.h
+++ b/tree-walk.h
@@ -22,7 +22,7 @@ static inline const unsigned char *tree_entry_extract(struct tree_desc *desc, co
static inline int tree_entry_len(const char *name, const unsigned char *sha1)
{
- return (char *)sha1 - (char *)name - 1;
+ return (const char *)sha1 - (const char *)name - 1;
}
void update_tree_entry(struct tree_desc *);
next reply other threads:[~2007-06-20 2:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 2:11 Luiz Fernando N. Capitulino [this message]
2007-06-23 6:19 ` [PATCH]: tree-walk.h: Warning fix Junio C Hamano
2007-06-24 2:10 ` Luiz Fernando N. Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070619231127.7ffe273b@gnut \
--to=lcapitulino@mandriva.com.br \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).