[PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Ismail Dönmez]

[-- Attachment #1.1: Type: text/plain, Size: 309 bytes --]

Hi,

According to FHS standard default man page path is $prefix/share/man [0] , 
attached patch fixes this for GIT.

[0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES

Signed-off-by: Ismail Donmez <ismail@pardus.org.tr>

Regards,
ismail

-- 
Le mieux est l'ennemi du bien.

[-- Attachment #1.2: mandir.patch --]
[-- Type: text/x-diff, Size: 309 bytes --]

--- Documentation/Makefile	2007-02-26 21:20:28.000000000 +0200
+++ Documentation/Makefile	2007-02-28 01:18:07.672166995 +0200
@@ -26,7 +26,7 @@
 
 prefix?=$(HOME)
 bindir?=$(prefix)/bin
-mandir?=$(prefix)/man
+mandir?=$(prefix)/share/man
 man1dir=$(mandir)/man1
 man7dir=$(mandir)/man7
 # DESTDIR=

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Uwe Kleine-König]

Hallo,

Ismail Dönmez wrote:
> According to FHS standard default man page path is $prefix/share/man [0] , 
> attached patch fixes this for GIT.
According to some GNU standard it's $prefix/man.

E.g. autoconf managed projects use $prefix/man if you don't give
--mandir=... to configure.

Personally I prefer FHS, so I have 

	mandir=$(prefix)/share/man

in my config.mak.

Best regards
Uwe

-- 
Uwe Kleine-König

http://www.google.com/search?q=72+PS+point+in+inch

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Ismail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

Hi,
On Tuesday 08 May 2007 18:02:20 Uwe Kleine-König wrote:
> Ismail Dönmez wrote:
> > According to FHS standard default man page path is $prefix/share/man [0]
> > , attached patch fixes this for GIT.
>
> According to some GNU standard it's $prefix/man.
>
> E.g. autoconf managed projects use $prefix/man if you don't give
> --mandir=... to configure.

Just noticed one can do make mandir=/usr/share/man

> Personally I prefer FHS, so I have
>
> 	mandir=$(prefix)/share/man
>
> in my config.mak.

Same here, IMHO FHS makes more sense and AFAIK most distros 
uses /usr/share/man.

Regards,
ismail

-- 
Le mieux est l'ennemi du bien.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Brian Gernhardt]

On May 8, 2007, at 11:02 AM, Uwe Kleine-König wrote:

> Personally I prefer FHS, so I have
>
> 	mandir=$(prefix)/share/man
>
> in my config.mak.

The Perl man files Git(3pm) and private-Error(3pm) seem to ignore  
that setting though.  :-(

I just have a "mybuild" target in config.mak that calls make all,  
doc, test, install, and install-doc before cleaning up files from the  
wrong places (man instead of share/man, Perl's System dir on OS X)  
and running "stow -R" to catch new files.

~~ Brian

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Ismail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

On Tuesday 08 May 2007 13:49:31 you wrote:
> Hi,
>
> According to FHS standard default man page path is $prefix/share/man [0] ,
> attached patch fixes this for GIT.
>
> [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES
>
> Signed-off-by: Ismail Donmez <ismail@pardus.org.tr>

ACK? NAK? Do we care about this? :)

Patch attached again for convenience.

Regards,
ismail

-- 
Perfect is the enemy of good

[-- Attachment #2: mandir.patch --]
[-- Type: text/x-diff, Size: 298 bytes --]

--- Documentation/Makefile	2007-02-26 21:20:28.000000000 +0200
+++ Documentation/Makefile	2007-02-28 01:18:07.672166995 +0200
@@ -26,7 +26,7 @@
 
 prefix?=$(HOME)
 bindir?=$(prefix)/bin
-mandir?=$(prefix)/man
+mandir?=$(prefix)/share/man
 man1dir=$(mandir)/man1
 man7dir=$(mandir)/man7
 # DESTDIR=

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Linus Torvalds]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 374 bytes --]



On Fri, 11 May 2007, Ismail Dönmez wrote:
> 
> ACK? NAK? Do we care about this? :)

I'll Ack it, for what it's worth.

As it is, I actually end up doing

	make prefix=/usr/local/share install-doc

(or something like that) to get things in the right place.

I think the old "$(prefix)/man" is just because I still mentally live in 
the early 90's most of the time.

		Linus

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Junio C Hamano]

Ismail Dönmez <ismail@pardus.org.tr> writes:

> On Tuesday 08 May 2007 13:49:31 you wrote:
>> Hi,
>>
>> According to FHS standard default man page path is $prefix/share/man [0] ,
>> attached patch fixes this for GIT.
>>
>> [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES
>>
>> Signed-off-by: Ismail Donmez <ismail@pardus.org.tr>
>
> ACK? NAK? Do we care about this? :)

I would not say the patch is wrong per-se, but:

 - People who do not override prefix to install in $HOME would
   suddenly get their mandir under $HOME/share/man; the fact
   nobody complained so far suggests me that these people have
   $MANPATH pointing at $HOME/man, which means your patch breaks
   things for them, unless they have been overriding mandir in
   which case your patch does not matter to them;

 - Distros who package git and want to conform to FHS would have
   been overriding not just prefix but mandir anyway, so your patch
   is not an improvement to them;

 - People who override prefix to install locally in /usr or
   /usr/local does "make prefix=" thing anyway, and the fact
   nobody complained so far suggests me that they have already
   known they need to override mandir as well if they do not
   like /usr/local/man, so your patch is not an improvement to
   them.

That makes one half negative plus two and half neutral.

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Ismail Dönmez]

On Friday 11 May 2007 22:27:35 you wrote:
> Ismail Dönmez <ismail@pardus.org.tr> writes:
> > On Tuesday 08 May 2007 13:49:31 you wrote:
> >> Hi,
> >>
> >> According to FHS standard default man page path is $prefix/share/man [0]
> >> , attached patch fixes this for GIT.
> >>
> >> [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES
> >>
> >> Signed-off-by: Ismail Donmez <ismail@pardus.org.tr>
> >
> > ACK? NAK? Do we care about this? :)
>
> I would not say the patch is wrong per-se, but:
>
>  - People who do not override prefix to install in $HOME would
>    suddenly get their mandir under $HOME/share/man; the fact
>    nobody complained so far suggests me that these people have
>    $MANPATH pointing at $HOME/man, which means your patch breaks
>    things for them, unless they have been overriding mandir in
>    which case your patch does not matter to them;

Or nobody is reading man pages? *g*

>  - Distros who package git and want to conform to FHS would have
>    been overriding not just prefix but mandir anyway, so your patch
>    is not an improvement to them;

True that.

>  - People who override prefix to install locally in /usr or
>    /usr/local does "make prefix=" thing anyway, and the fact
>    nobody complained so far suggests me that they have already
>    known they need to override mandir as well if they do not
>    like /usr/local/man, so your patch is not an improvement to
>    them.

Most(All?) distros /usr/share/man in MANPATH so I believe this patch shouldn't 
break anything but well you have the final say. I am ok with doing   
make mandir=/usr/share/man install-doc .

Regards,
ismail

-- 
Perfect is the enemy of good

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Junio C Hamano]

Ismail Dönmez <ismail@pardus.org.tr> writes:

> Most(All?) distros /usr/share/man in MANPATH so I believe this
> patch shouldn't break anything but well you have the final
> say. I am ok with doing make mandir=/usr/share/man install-doc

My preference is to do this early after 1.5.2.  I do not want to
touch builds with trivial changes before the final.

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Ismail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

On Friday 11 May 2007 22:44:06 Junio C Hamano wrote:
> Ismail Dönmez <ismail@pardus.org.tr> writes:
> > Most(All?) distros /usr/share/man in MANPATH so I believe this
> > patch shouldn't break anything but well you have the final
> > say. I am ok with doing make mandir=/usr/share/man install-doc
>
> My preference is to do this early after 1.5.2.  I do not want to
> touch builds with trivial changes before the final.

Ok with me, thank you.

Regards,
ismail

-- 
Perfect is the enemy of good

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Ismail Dönmez]

[-- Attachment #1.1: Type: text/plain, Size: 551 bytes --]

On Friday 11 May 2007 22:44:06 Junio C Hamano wrote:
> Ismail Dönmez <ismail@pardus.org.tr> writes:
> > Most(All?) distros /usr/share/man in MANPATH so I believe this
> > patch shouldn't break anything but well you have the final
> > say. I am ok with doing make mandir=/usr/share/man install-doc
>
> My preference is to do this early after 1.5.2.  I do not want to
> touch builds with trivial changes before the final.

Still not applied to 1.5.2.2. Patch attached for convenience.

Regards,
ismail

-- 
Perfect is the enemy of good

[-- Attachment #1.2: mandir.patch --]
[-- Type: text/x-diff, Size: 309 bytes --]

--- Documentation/Makefile	2007-02-26 21:20:28.000000000 +0200
+++ Documentation/Makefile	2007-02-28 01:18:07.672166995 +0200
@@ -26,7 +26,7 @@
 
 prefix?=$(HOME)
 bindir?=$(prefix)/bin
-mandir?=$(prefix)/man
+mandir?=$(prefix)/share/man
 man1dir=$(mandir)/man1
 man7dir=$(mandir)/man7
 # DESTDIR=

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

[Junio C Hamano]

Ismail Dönmez <ismail@pardus.org.tr> writes:

> On Friday 11 May 2007 22:44:06 Junio C Hamano wrote:
>> Ismail Dönmez <ismail@pardus.org.tr> writes:
>> > Most(All?) distros /usr/share/man in MANPATH so I believe this
>> > patch shouldn't break anything but well you have the final
>> > say. I am ok with doing make mandir=/usr/share/man install-doc
>>
>> My preference is to do this early after 1.5.2.  I do not want to
>> touch builds with trivial changes before the final.
>
> Still not applied to 1.5.2.2. Patch attached for convenience.

Thanks.

I do not think this patch should happen to 1.5.2.X for any value
of X; but I am willing to apply it to 'master' (hence 1.5.3 and
later).