From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [RFC PATCH 2/2] Teach git-blame --gui how to start git-gui blame
Date: Fri, 22 Jun 2007 00:47:16 -0400 [thread overview]
Message-ID: <20070622044716.GG17393@spearce.org> (raw)
In-Reply-To: <7vzm2sab63.fsf@assigned-by-dhcp.pobox.com>
Junio C Hamano <gitster@pobox.com> wrote:
> This is only minor nuisance, but can we do something about this?
>
> $ git gui --version
> Application initialization failed: no display name and no $DISPLAY environment variable
>
> I know it is from wish, not you, so I wouldn't insist, though.
Actually that should be fixable.
Should be as simple as using a Bourne shell script up front to
check for "z$1" = zversion || "z$1" = z--version, and if so dump
back the version, otherwise exec wish. This is actually quite easy
and won't change things for existing users. I'll put a patch into
maint tonight for it.
--
Shawn.
next prev parent reply other threads:[~2007-06-22 4:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-21 4:53 [RFC PATCH 2/2] Teach git-blame --gui how to start git-gui blame Shawn O. Pearce
2007-06-21 6:19 ` Junio C Hamano
2007-06-22 3:56 ` Shawn O. Pearce
2007-06-22 4:03 ` Junio C Hamano
2007-06-22 4:47 ` Shawn O. Pearce [this message]
2007-06-22 5:20 ` Junio C Hamano
2007-06-22 5:37 ` Shawn O. Pearce
2007-06-22 8:02 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070622044716.GG17393@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).