Re: [RFC PATCH 2/2] Teach git-blame --gui how to start git-gui blame

["Shawn O. Pearce" <spearce@spearce.org>]

Junio C Hamano <gitster@pobox.com> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> > Junio C Hamano <gitster@pobox.com> wrote:
> >> This is only minor nuisance, but can we do something about this?
> >> 
> >>  $ git gui --version
> >>  Application initialization failed: no display name and no $DISPLAY environment variable
> >> 
> >> I know it is from wish, not you, so I wouldn't insist, though.
> 
> If this makes life any harder to people on Windows, especially
> minGW, I would suggest against it.

Its already done.  I don't think it will make a difference either
way right now.

Currently we still have to have a Bourne shell on both Cygwin
and MINGW platforms to perform key actions, like say git-clone.
The startup cost of git-gui is also rather high there anyway, so
this extra if test in Bourne shell before we exec into Tcl isn't
going to kill us.

Besides, you can side-step the entire Bourne shell thing by just
starting git-gui in wish yourself.  E.g.

  CALL /path/to/wish.exe /path/to/git-gui -- ...


I'd like to come back and make git-gui easier to install, perhaps by
making "starpacks" of git-gui and Git plumbing available for some
popular systems (e.g. MINGW/Windows, Mac OS X).  Such starpacks
would give users an easy way to get git-gui (and thus basic Git)
up and running quickly.  At that point I will need to revisit this
bootstrap code anyway.

-- 
Shawn.